Patchwork log: flag topo-sorted set as such

login
register
mail settings
Submitter Yuya Nishihara
Date May 15, 2019, 11:24 p.m.
Message ID <77eb2f52d411836a9f7c.1557962675@mimosa>
Download mbox | patch
Permalink /patch/40072/
State Accepted
Headers show

Comments

Yuya Nishihara - May 15, 2019, 11:24 p.m.
# HG changeset patch
# User Yuya Nishihara <yuya@tcha.org>
# Date 1557962120 -32400
#      Thu May 16 08:15:20 2019 +0900
# Node ID 77eb2f52d411836a9f7cadd7b3c7d095945cadcc
# Parent  52c3d16d4c62567e4858ddc8c082443a1f7a2f78
log: flag topo-sorted set as such

This isn't required right now, but revs.istopo() should return True.
via Mercurial-devel - May 15, 2019, 11:46 p.m.
On Wed, May 15, 2019 at 4:34 PM Yuya Nishihara <yuya@tcha.org> wrote:

> # HG changeset patch
> # User Yuya Nishihara <yuya@tcha.org>
> # Date 1557962120 -32400
> #      Thu May 16 08:15:20 2019 +0900
> # Node ID 77eb2f52d411836a9f7cadd7b3c7d095945cadcc
> # Parent  52c3d16d4c62567e4858ddc8c082443a1f7a2f78
> log: flag topo-sorted set as such
>

Queued, thanks.

Patch

diff --git a/mercurial/logcmdutil.py b/mercurial/logcmdutil.py
--- a/mercurial/logcmdutil.py
+++ b/mercurial/logcmdutil.py
@@ -750,7 +750,7 @@  def getrevs(repo, pats, opts):
             if not revs.istopo():
                 revs = dagop.toposort(revs, repo.changelog.parentrevs)
                 # TODO: try to iterate the set lazily
-                revs = revset.baseset(list(revs))
+                revs = revset.baseset(list(revs), istopo=True)
         elif not (revs.isdescending() or revs.istopo()):
             revs.sort(reverse=True)
     if expr: