Patchwork D6372: log: remove an unnecessary "and opts.get('rev')" condition

login
register
mail settings
Submitter phabricator
Date May 14, 2019, 4:34 p.m.
Message ID <differential-rev-PHID-DREV-aakliyzpfjk3xttutkxi-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/40016/
State Superseded
Headers show

Comments

phabricator - May 14, 2019, 4:34 p.m.
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  As Yuya pointed out, the condition is unnecessary since
  revs.isdescending() would be true if --follow without --rev.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6372

AFFECTED FILES
  mercurial/logcmdutil.py

CHANGE DETAILS




To: martinvonz, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/mercurial/logcmdutil.py b/mercurial/logcmdutil.py
--- a/mercurial/logcmdutil.py
+++ b/mercurial/logcmdutil.py
@@ -743,7 +743,7 @@ 
             return match
 
     expr = _makerevset(repo, match, pats, slowpath, opts)
-    if opts.get('graph') and opts.get('rev'):
+    if opts.get('graph'):
         # User-specified revs might be unsorted, but don't sort before
         # _makerevset because it might depend on the order of revs
         if not (revs.isdescending() or revs.istopo()):