Patchwork D6352: copies: delete misplaced comment

login
register
mail settings
Submitter phabricator
Date May 7, 2019, 10:17 p.m.
Message ID <differential-rev-PHID-DREV-qjfckl643qv2ihop4r5u-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/39980/
State Superseded
Headers show

Comments

phabricator - May 7, 2019, 10:17 p.m.
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  The comment was added in https://phab.mercurial-scm.org/rHG78d760aa3607f13c8d24b9a6807aa998c4d61f0a (duplicatecopies: do not mark
  items not in the dirstate as copies, 2013-03-28). It became misplaced
  in https://phab.mercurial-scm.org/rHG3666331164bb014b9b7b2a56d4171ef4cbb5e4d6 (cmdutil: add copy-filtering support to
  duplicatecopies, 2014-06-07). Then the relevant code was moved far
  away in https://phab.mercurial-scm.org/rHG754b5117622f2a60c408fcd61fa6183ccb1c1e92 (context: add workingfilectx.markcopied,
  2017-10-15).

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6352

AFFECTED FILES
  mercurial/copies.py

CHANGE DETAILS




To: martinvonz, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/mercurial/copies.py b/mercurial/copies.py
--- a/mercurial/copies.py
+++ b/mercurial/copies.py
@@ -796,8 +796,6 @@ 
         # metadata across the rebase anyway).
         exclude = pathcopies(repo[fromrev], repo[skiprev])
     for dst, src in pathcopies(repo[fromrev], repo[rev]).iteritems():
-        # copies.pathcopies returns backward renames, so dst might not
-        # actually be in the dirstate
         if dst in exclude:
             continue
         wctx[dst].markcopied(src)