Patchwork D6340: repair: reword comment about bookmarks logic

login
register
mail settings
Submitter phabricator
Date May 4, 2019, 2:37 p.m.
Message ID <differential-rev-PHID-DREV-iedskdzhqyryv6zovkoh-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/39946/
State Superseded
Headers show

Comments

phabricator - May 4, 2019, 2:37 p.m.
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  Again, this will help auto-formatting shortly.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6340

AFFECTED FILES
  mercurial/repair.py

CHANGE DETAILS




To: durin42, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/mercurial/repair.py b/mercurial/repair.py
--- a/mercurial/repair.py
+++ b/mercurial/repair.py
@@ -279,7 +279,9 @@ 
         if rev in tostrip:
             updatebm.append(m)
     newbmtarget = None
-    if updatebm: # don't compute anything is there is no bookmark to move anyway
+    # If we need to move bookmarks, compute bookmark
+    # targets. Otherwise we can skip doing this logic.
+    if updatebm:
         # For a set s, max(parents(s) - s) is the same as max(heads(::s - s)),
         # but is much faster
         newbmtarget = repo.revs('max(parents(%ld) - (%ld))', tostrip, tostrip)