Patchwork D6289: unionrepo: sync with repository API

login
register
mail settings
Submitter phabricator
Date April 19, 2019, 6:06 p.m.
Message ID <differential-rev-PHID-DREV-d3ijaexp5gxmnybryuxg-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/39770/
State Superseded
Headers show

Comments

phabricator - April 19, 2019, 6:06 p.m.
joerg.sonnenberger created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6289

AFFECTED FILES
  mercurial/unionrepo.py

CHANGE DETAILS




To: joerg.sonnenberger, #hg-reviewers
Cc: mercurial-devel
phabricator - April 24, 2019, 7 p.m.
martinvonz added inline comments.

INLINE COMMENTS

> unionrepo.py:131
>          raise NotImplementedError
> -    def addgroup(self, deltas, transaction, addrevisioncb=None):
> +    def addgroup(self, deltas, linkmapper, transaction, addrevisioncb=None, maybemissingparents=False):
>          raise NotImplementedError

Line too long, but i'll fix that in flight. Please run test-check-code.t next time

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6289

To: joerg.sonnenberger, #hg-reviewers
Cc: martinvonz, mercurial-devel

Patch

diff --git a/mercurial/unionrepo.py b/mercurial/unionrepo.py
--- a/mercurial/unionrepo.py
+++ b/mercurial/unionrepo.py
@@ -128,9 +128,9 @@ 
 
     def addrevision(self, text, transaction, link, p1=None, p2=None, d=None):
         raise NotImplementedError
-    def addgroup(self, deltas, transaction, addrevisioncb=None):
+    def addgroup(self, deltas, linkmapper, transaction, addrevisioncb=None, maybemissingparents=False):
         raise NotImplementedError
-    def strip(self, rev, minlink):
+    def strip(self, minlink, transaction):
         raise NotImplementedError
     def checksize(self):
         raise NotImplementedError