Patchwork D6287: automation: wait longer for WinRM connection

login
register
mail settings
Submitter phabricator
Date April 19, 2019, 2:41 p.m.
Message ID <differential-rev-PHID-DREV-mh6zosvzgwvkksggn4jr-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/39768/
State Superseded
Headers show

Comments

phabricator - April 19, 2019, 2:41 p.m.
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  I got a few timeouts waiting for only 120s for the WinRM connection
  to become available. Increasing to 180s seems to fix. I guess
  AWS isn't as consistent as I would like :(

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6287

AFFECTED FILES
  contrib/automation/hgautomation/winrm.py

CHANGE DETAILS




To: indygreg, #hg-reviewers
Cc: mercurial-devel
phabricator - May 15, 2019, 3:43 p.m.
martinvonz accepted this revision.
martinvonz added a comment.
This revision is now accepted and ready to land.


  I think I asked on #mercurial a while ago if anyone knew enough about Windows packaging to review this. No one said anything. So I can't see any reason *not* to queue this series.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6287

To: indygreg, #hg-reviewers, martinvonz
Cc: martinvonz, mercurial-devel

Patch

diff --git a/contrib/automation/hgautomation/winrm.py b/contrib/automation/hgautomation/winrm.py
--- a/contrib/automation/hgautomation/winrm.py
+++ b/contrib/automation/hgautomation/winrm.py
@@ -25,7 +25,7 @@ 
 logger = logging.getLogger(__name__)
 
 
-def wait_for_winrm(host, username, password, timeout=120, ssl=False):
+def wait_for_winrm(host, username, password, timeout=180, ssl=False):
     """Wait for the Windows Remoting (WinRM) service to become available.
 
     Returns a ``psrpclient.Client`` instance.