Patchwork [2,of,2] rust: getting back to versions 0.1.0

login
register
mail settings
Submitter Georges Racinet
Date April 16, 2019, 7:26 p.m.
Message ID <9f79564faefa97d9221b.1555442778@purity.tombe.racinet.fr>
Download mbox | patch
Permalink /patch/39665/
State New
Headers show

Comments

Georges Racinet - April 16, 2019, 7:26 p.m.
# HG changeset patch
# User Georges Racinet <georges.racinet@octobus.net>
# Date 1555442327 -7200
#      Tue Apr 16 21:18:47 2019 +0200
# Node ID 9f79564faefa97d9221bd59f913691cf9df9ff64
# Parent  410396d5eca793a1b8cf9ee8ba7bce466e9be3c0
# EXP-Topic rust-crates.io
rust: getting back to versions 0.1.0

This ensures that existing development versions take
precedence over the 0.0.1s I have sent to crates.io

Note about the update process

The [patch] section of the workspace having precedence
on the various manifests, it comes in contradiction
with the precise specification of Cargo.lock.

To solve that, one simply has to do:

  cargo update -p hg-core

and commit the resulting changes in rust/Cargo.lock
I expect this to be part of the post-release routine.

As a side note, the general guidelines say that libraries
should not commit their Cargo.lock, whereas executable binaries should.

  https://doc.rust-lang.org/cargo/faq.html#why-do-binaries-have-cargolock-in-version-control-but-not-libraries

We'd like to argue that hg-cpython and hg-direct-ffi are to be considered
binaries, and that for them, that role is fulfilled by the Cargo.lock at the workspace
level, which is in version control.

Patch

diff -r 410396d5eca7 -r 9f79564faefa rust/Cargo.lock
--- a/rust/Cargo.lock	Tue Apr 16 21:09:44 2019 +0200
+++ b/rust/Cargo.lock	Tue Apr 16 21:18:47 2019 +0200
@@ -48,6 +48,11 @@ 
 [[package]]
 name = "hg-core"
 version = "0.0.1"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+
+[[package]]
+name = "hg-core"
+version = "0.1.0"
 dependencies = [
  "rand 0.6.5 (registry+https://github.com/rust-lang/crates.io-index)",
  "rand_pcg 0.1.1 (registry+https://github.com/rust-lang/crates.io-index)",
@@ -55,10 +60,10 @@ 
 
 [[package]]
 name = "hg-cpython"
-version = "0.0.1"
+version = "0.1.0"
 dependencies = [
  "cpython 0.2.1 (registry+https://github.com/rust-lang/crates.io-index)",
- "hg-core 0.0.1",
+ "hg-core 0.0.1 (registry+https://github.com/rust-lang/crates.io-index)",
  "libc 0.2.45 (registry+https://github.com/rust-lang/crates.io-index)",
  "python27-sys 0.2.1 (registry+https://github.com/rust-lang/crates.io-index)",
  "python3-sys 0.2.1 (registry+https://github.com/rust-lang/crates.io-index)",
@@ -68,7 +73,7 @@ 
 name = "hgdirectffi"
 version = "0.1.0"
 dependencies = [
- "hg-core 0.0.1",
+ "hg-core 0.0.1 (registry+https://github.com/rust-lang/crates.io-index)",
  "libc 0.2.45 (registry+https://github.com/rust-lang/crates.io-index)",
 ]
 
@@ -310,6 +315,7 @@ 
 "checksum cloudabi 0.0.3 (registry+https://github.com/rust-lang/crates.io-index)" = "ddfc5b9aa5d4507acaf872de71051dfd0e309860e88966e1051e462a077aac4f"
 "checksum cpython 0.2.1 (registry+https://github.com/rust-lang/crates.io-index)" = "b489034e723e7f5109fecd19b719e664f89ef925be785885252469e9822fa940"
 "checksum fuchsia-cprng 0.1.0 (registry+https://github.com/rust-lang/crates.io-index)" = "81f7f8eb465745ea9b02e2704612a9946a59fa40572086c6fd49d6ddcf30bf31"
+"checksum hg-core 0.0.1 (registry+https://github.com/rust-lang/crates.io-index)" = "7fe168efadebadb9da6a329fdc027036e233b662285730cad27220e11e53c384"
 "checksum lazy_static 1.2.0 (registry+https://github.com/rust-lang/crates.io-index)" = "a374c89b9db55895453a74c1e38861d9deec0b01b405a82516e9d5de4820dea1"
 "checksum libc 0.2.45 (registry+https://github.com/rust-lang/crates.io-index)" = "2d2857ec59fadc0773853c664d2d18e7198e83883e7060b63c924cb077bd5c74"
 "checksum memchr 2.1.2 (registry+https://github.com/rust-lang/crates.io-index)" = "db4c41318937f6e76648f42826b1d9ade5c09cafb5aef7e351240a70f39206e9"
diff -r 410396d5eca7 -r 9f79564faefa rust/hg-core/Cargo.toml
--- a/rust/hg-core/Cargo.toml	Tue Apr 16 21:09:44 2019 +0200
+++ b/rust/hg-core/Cargo.toml	Tue Apr 16 21:18:47 2019 +0200
@@ -1,6 +1,6 @@ 
 [package]
 name = "hg-core"
-version = "0.0.1"
+version = "0.1.0"
 authors = ["Georges Racinet <georges.racinett@octobus.net>"]
 description = "Mercurial pure Rust core library, with no assumption on Python bindings (FFI)"
 license = "GPL-2.0-or-later"
diff -r 410396d5eca7 -r 9f79564faefa rust/hg-cpython/Cargo.toml
--- a/rust/hg-cpython/Cargo.toml	Tue Apr 16 21:09:44 2019 +0200
+++ b/rust/hg-cpython/Cargo.toml	Tue Apr 16 21:18:47 2019 +0200
@@ -1,6 +1,6 @@ 
 [package]
 name = "hg-cpython"
-version = "0.0.1"
+version = "0.1.0"
 authors = ["Georges Racinet <georges.racinett@octobus.net>"]
 description = "Mercurial Python bindings using the cpython crate"
 license = "GPL-2.0-or-later"