Patchwork D6225: rebase: demonstrate bug in dry-run mode which causes cycles to not be reported

login
register
mail settings
Submitter phabricator
Date April 12, 2019, 5:28 p.m.
Message ID <62ce18d7b7bf3e6cc6b7b6f54078c933@localhost.localdomain>
Download mbox | patch
Permalink /patch/39571/
State Not Applicable
Headers show

Comments

phabricator - April 12, 2019, 5:28 p.m.
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG8890fce7c13d: rebase: demonstrate bug in dry-run mode which causes cycles to not be reported (authored by durin42, committed by ).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D6225?vs=14712&id=14715

REVISION DETAIL
  https://phab.mercurial-scm.org/D6225

AFFECTED FILES
  tests/test-rebase-dest.t

CHANGE DETAILS




To: durin42, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/tests/test-rebase-dest.t b/tests/test-rebase-dest.t
--- a/tests/test-rebase-dest.t
+++ b/tests/test-rebase-dest.t
@@ -206,6 +206,18 @@ 
   abort: source and destination form a cycle
   [255]
 
+BUG: cycles aren't flagged correctly when --dry-run is set:
+  $ rebasewithdag -s B -d 'SRC' --dry-run <<'EOS'
+  > C
+  > |
+  > B
+  > |
+  > Z
+  > EOS
+  abort: no rebase in progress
+  starting dry-run rebase; repository will not be changed
+  [255]
+
 Switch roots:
 
   $ rebasewithdag -s 'all() - roots(all())' -d 'roots(all()) - ::SRC' <<'EOS'