Patchwork D6213: tests: demonstrate broken `hg convert` if "ffffffffffff" is in description

login
register
mail settings
Submitter phabricator
Date April 8, 2019, 6:50 p.m.
Message ID <c64d49ffce7104151a388fc0de0134a2@localhost.localdomain>
Download mbox | patch
Permalink /patch/39538/
State Not Applicable
Headers show

Comments

phabricator - April 8, 2019, 6:50 p.m.
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGb8c2dc367cc3: tests: demonstrate broken `hg convert` if &quot;ffffffffffff&quot; is in description (authored by martinvonz, committed by ).

CHANGED PRIOR TO COMMIT
  https://phab.mercurial-scm.org/D6213?vs=14687&id=14694#toc

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D6213?vs=14687&id=14694

REVISION DETAIL
  https://phab.mercurial-scm.org/D6213

AFFECTED FILES
  tests/test-convert-hg-source.t

CHANGE DETAILS




To: martinvonz, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/tests/test-convert-hg-source.t b/tests/test-convert-hg-source.t
--- a/tests/test-convert-hg-source.t
+++ b/tests/test-convert-hg-source.t
@@ -214,10 +214,14 @@ 
   $ hg ci -Aqm initial
   $ echo b > b
   $ hg ci -Aqm 'the previous commit was 1451231c8757'
+  $ echo c > c
+  $ hg ci -Aqm 'the working copy is called ffffffffffff'
 
   $ cd ..
+BROKEN: crashes when the "ffffffffffff" is encountered
   $ hg convert commit-references new-commit-references -q \
-  >     --config convert.hg.sourcename=yes
+  >     --config convert.hg.sourcename=yes 2>&1 | grep TypeError
+  TypeError: b2a_hex() argument 1 must be string or buffer, not None
   $ cd new-commit-references
   $ hg log -T '{node|short} {desc}\n'
   642508659503 the previous commit was c2491f685436