Patchwork [6,of,8] match: make _donormalize's auditor and warn arguments optional

mail settings
Submitter Denis Laxalde
Date April 8, 2019, 8:23 a.m.
Message ID <>
Download mbox | patch
Permalink /patch/39531/
State Accepted
Headers show


Denis Laxalde - April 8, 2019, 8:23 a.m.
# HG changeset patch
# User Denis Laxalde <>
# Date 1554650069 -7200
#      Sun Apr 07 17:14:29 2019 +0200
# Node ID a544e90f7c163576fe84234b024bf0c0052d995e
# Parent  c7e9ddf8b24e9768d331872af1e61cd5d65c3668
match: make _donormalize's auditor and warn arguments optional

Argument 'warn' is actually non-required, since there's a 'if warn:'
check before usage. Argument 'auditor' is passed to
pathutil.canonpath(), in which it is optional.


diff --git a/mercurial/ b/mercurial/
--- a/mercurial/
+++ b/mercurial/
@@ -256,13 +256,13 @@  def badmatch(match, badfn):
     m.bad = badfn
     return m
-def _donormalize(patterns, default, root, cwd, auditor, warn):
+def _donormalize(patterns, default, root, cwd, auditor=None, warn=None):
     '''Convert 'kind:pat' from the patterns list to tuples with kind and
     normalized and rooted patterns and with listfiles expanded.'''
     kindpats = []
     for kind, pat in [_patsplit(p, default) for p in patterns]:
         if kind in cwdrelativepatternkinds:
-            pat = pathutil.canonpath(root, cwd, pat, auditor)
+            pat = pathutil.canonpath(root, cwd, pat, auditor=auditor)
         elif kind in ('relglob', 'path', 'rootfilesin', 'rootglob'):
             pat = util.normpath(pat)
         elif kind in ('listfile', 'listfile0'):