Patchwork D6213: tests: demonstrate broken `hg convert` if "ffffffffffff" is in description

login
register
mail settings
Submitter phabricator
Date April 5, 2019, 6:34 p.m.
Message ID <differential-rev-PHID-DREV-mclgccn66uiilszapqvw-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/39511/
State Superseded
Headers show

Comments

phabricator - April 5, 2019, 6:34 p.m.
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6213

AFFECTED FILES
  tests/test-convert-hg-source.t

CHANGE DETAILS




To: martinvonz, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/tests/test-convert-hg-source.t b/tests/test-convert-hg-source.t
--- a/tests/test-convert-hg-source.t
+++ b/tests/test-convert-hg-source.t
@@ -217,10 +217,14 @@ 
   $ hg ci -Aqm initial
   $ echo b > b
   $ hg ci -Aqm 'the previous commit was 3ccbd4cbba95'
+  $ echo c > c
+  $ hg ci -Aqm 'the working copy is called ffffffffffff'
 
   $ cd ..
+BROKEN: crashes when the "ffffffffffff" is encountered
   $ hg convert commit-references new-commit-references -q \
-  >     --config convert.hg.startrev=1
+  >     --config convert.hg.startrev=1 2>&1 | grep TypeError
+  TypeError: b2a_hex() argument 1 must be string or buffer, not None
   $ cd new-commit-references
   $ hg log -T '{node|short} {desc}\n'
   38a97fe212e7 the previous commit was 3cf70f7c1f3b