Patchwork D6195: test/test-revset2.t: Unset environment variable P (issue1609)

login
register
mail settings
Submitter phabricator
Date April 4, 2019, 2:33 p.m.
Message ID <differential-rev-PHID-DREV-aympkbhsvlt62gthgbkk-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/39476/
State Superseded
Headers show

Comments

phabricator - April 4, 2019, 2:33 p.m.
jerry.montfort created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  The test tests/test-revset2.t fails the test case
  
  "Test repo.anyrevs with customized revset overrides" (line 1609)
  
  if the environment variable P is set. The test implicitly expects that the
  environment, in which it is started, does not export the variable 'P'.
  
  To solve this issue, unset 'P' right before the test commands are run.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6195

AFFECTED FILES
  tests/test-revset2.t

CHANGE DETAILS




To: jerry.montfort, #hg-reviewers
Cc: mercurial-devel
phabricator - April 4, 2019, 2:43 p.m.
jerry.montfort added a comment.


  Note: I had a typo in the issue number: I used the line number which happens to have the exact same digits as the issue number (must be destiny). To fix the typo I used the "Edit Revision" button on this web page. If that's the wrong way, I'll resend the patch if required.
  For the record: The issue number is issue6109 (and the line number 1609).

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6195

To: jerry.montfort, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/tests/test-revset2.t b/tests/test-revset2.t
--- a/tests/test-revset2.t
+++ b/tests/test-revset2.t
@@ -1627,6 +1627,7 @@ 
   > printprevset = $TESTTMP/printprevset.py
   > EOF
 
+  $ unset P
   $ hg --config revsetalias.P=1 printprevset
   P=[1]
   $ P=3 hg --config revsetalias.P=2 printprevset