Submitter | phabricator |
---|---|
Date | April 3, 2019, 7:04 a.m. |
Message ID | <differential-rev-PHID-DREV-rwk2xtkmiazfzufgw5m3-req@phab.mercurial-scm.org> |
Download | mbox | patch |
Permalink | /patch/39460/ |
State | Superseded |
Headers | show |
Comments
pulkit added a comment. Hi, the patch looks good. However, this lacks User info, Date and other metadata. Can you try using `hg phabsend` (https://www.mercurial-scm.org/wiki/Phabricator) or `hg email` the patch? (https://www.mercurial-scm.org/wiki/ContributingChanges#Sending_patches) Also, append the commit description with (issueNNN) as suggested by https://www.mercurial-scm.org/wiki/ContributingChanges#Patch_descriptions. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6188 To: jerry.montfort, #hg-reviewers Cc: pulkit, mercurial-devel
jerry.montfort added a comment. Hi, Used hg phasbsend which created https://phab.mercurial-scm.org/D6195. I've no clue how to merge/handle these two, so feel free to intervene. Also added issueNNN to the commit description as suggested. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6188 To: jerry.montfort, #hg-reviewers Cc: pulkit, mercurial-devel
pulkit added a comment. In https://phab.mercurial-scm.org/D6188#90212, @jerry.montfort wrote: > Hi, Used hg phasbsend which created https://phab.mercurial-scm.org/D6195. I've no clue how to merge/handle these two, so feel free to intervene. > Also added issueNNN to the commit description as suggested. Thanks for the updated patch, I pushed it yesterday. This can be marked as Abandoned from the phabricator UI. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6188 To: jerry.montfort, #hg-reviewers Cc: pulkit, mercurial-devel
jerry.montfort abandoned this revision. jerry.montfort added a comment. Thanks @pulkit! Abandoning revision as you suggested. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6188 To: jerry.montfort, #hg-reviewers Cc: pulkit, mercurial-devel
Patch
diff --git a/tests/test-revset2.t b/tests/test-revset2.t --- a/tests/test-revset2.t +++ b/tests/test-revset2.t @@ -1627,6 +1627,7 @@ > printprevset = $TESTTMP/printprevset.py > EOF + $ unset P $ hg --config revsetalias.P=1 printprevset P=[1] $ P=3 hg --config revsetalias.P=2 printprevset