Patchwork D6187: wix: fix the package build when not adding features

login
register
mail settings
Submitter phabricator
Date April 3, 2019, 4:05 a.m.
Message ID <differential-rev-PHID-DREV-wd2rnaftdqazhoe6conz-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/39459/
State Superseded
Headers show

Comments

phabricator - April 3, 2019, 4:05 a.m.
durin42 created this revision.
durin42 added a reviewer: indygreg.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  Should have used ifdef, not if. Sigh.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6187

AFFECTED FILES
  contrib/packaging/wix/mercurial.wxs

CHANGE DETAILS




To: durin42, indygreg, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/contrib/packaging/wix/mercurial.wxs b/contrib/packaging/wix/mercurial.wxs
--- a/contrib/packaging/wix/mercurial.wxs
+++ b/contrib/packaging/wix/mercurial.wxs
@@ -129,7 +129,7 @@ 
         <MergeRef Id='VCRuntime' />
         <MergeRef Id='VCRuntimePolicy' />
       </Feature>
-      <?if $(var.MercurialExtraFeatures)?>
+      <?ifdef MercurialExtraFeatures?>
         <?foreach EXTRAFEAT in $(var.MercurialExtraFeatures)?>
           <FeatureRef Id="$(var.EXTRAFEAT)" />
         <?endforeach?>