Patchwork D6176: revset: remove comment about linkrev workaround from user-facing docs

login
register
mail settings
Submitter phabricator
Date March 31, 2019, 4:43 p.m.
Message ID <differential-rev-PHID-DREV-hnpowbh44hb2vb3bfufn-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/39429/
State Superseded
Headers show

Comments

phabricator - March 31, 2019, 4:43 p.m.
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  I think the code is clear enough so we don't need to keep the comment
  at all (by now, most Mercurial developers are probably familiar with
  the linkrevs issues).

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6176

AFFECTED FILES
  mercurial/revset.py

CHANGE DETAILS




To: martinvonz, #hg-reviewers
Cc: mercurial-devel
Pierre-Yves David - March 31, 2019, 5:02 p.m.
+1

On 3/31/19 5:43 PM, martinvonz (Martin von Zweigbergk) wrote:
> martinvonz created this revision.
> Herald added a subscriber: mercurial-devel.
> Herald added a reviewer: hg-reviewers.
> 
> REVISION SUMMARY
>    I think the code is clear enough so we don't need to keep the comment
>    at all (by now, most Mercurial developers are probably familiar with
>    the linkrevs issues).
> 
> REPOSITORY
>    rHG Mercurial
> 
> REVISION DETAIL
>    https://phab.mercurial-scm.org/D6176
> 
> AFFECTED FILES
>    mercurial/revset.py
> 
> CHANGE DETAILS
> 
> diff --git a/mercurial/revset.py b/mercurial/revset.py
> --- a/mercurial/revset.py
> +++ b/mercurial/revset.py
> @@ -960,9 +960,6 @@
>       The pattern without explicit kind like ``glob:`` is expected to be
>       relative to the current directory and match against a file exactly
>       for efficiency.
> -
> -    If some linkrev points to revisions filtered by the current repoview, we'll
> -    work around it to return a non-filtered value.
>       """
>   
>       # i18n: "filelog" is a keyword
> 
> 
> 
> To: martinvonz, #hg-reviewers
> Cc: mercurial-devel
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
>
phabricator - March 31, 2019, 5:02 p.m.
marmoute added a comment.


  +1

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6176

To: martinvonz, #hg-reviewers
Cc: marmoute, mercurial-devel

Patch

diff --git a/mercurial/revset.py b/mercurial/revset.py
--- a/mercurial/revset.py
+++ b/mercurial/revset.py
@@ -960,9 +960,6 @@ 
     The pattern without explicit kind like ``glob:`` is expected to be
     relative to the current directory and match against a file exactly
     for efficiency.
-
-    If some linkrev points to revisions filtered by the current repoview, we'll
-    work around it to return a non-filtered value.
     """
 
     # i18n: "filelog" is a keyword