Patchwork [Bug,6109] New: tests/test-revset2.t fails when environment variable P is set

login
register
mail settings
Submitter mercurial-bugs@mercurial-scm.org
Date March 30, 2019, 5:17 a.m.
Message ID <bug-6109-285@https.bz.mercurial-scm.org/>
Download mbox | patch
Permalink /patch/39418/
State Not Applicable
Headers show

Comments

mercurial-bugs@mercurial-scm.org - March 30, 2019, 5:17 a.m.
https://bz.mercurial-scm.org/show_bug.cgi?id=6109

            Bug ID: 6109
           Summary: tests/test-revset2.t fails when environment variable P
                    is set
           Product: Mercurial
           Version: unspecified
          Hardware: All
                OS: Linux
            Status: UNCONFIRMED
          Severity: bug
          Priority: normal
         Component: revset
          Assignee: bugzilla@mercurial-scm.org
          Reporter: jerry.montfort@fake-box.com
                CC: mercurial-devel@mercurial-scm.org

Created attachment 2038
  --> https://bz.mercurial-scm.org/attachment.cgi?id=2038&action=edit
unset environment variable P in tests/test-revset2.t

tests/test-revset2.t fails the test

"Test repo.anyrevs with customized revset overrides" (line 1609)

when the environment variable P is set. The test implicitly expects that the
environment, in which it is started, does not export the variable 'P'.

One solution would be to unset the variable P before running the test command
(patch based on the mercurial 4.9 tarball; also attached):

Patch

--- a/tests/test-revset2.t
+++ b/tests/test-revset2.t
@@ -1627,6 +1627,7 @@  Test repo.anyrevs with customized revset overrides
   > printprevset = $TESTTMP/printprevset.py
   > EOF

+  $ unset P
   $ hg --config revsetalias.P=1 printprevset
   P=[1]
   $ P=3 hg --config revsetalias.P=2 printprevset