Patchwork chistedit: change in-progress message

login
register
mail settings
Submitter Jordi Gutiérrez Hermoso
Date March 26, 2019, 3:57 p.m.
Message ID <5184a81a2a3b85327e15.1553615840@chloe>
Download mbox | patch
Permalink /patch/39386/
State Accepted
Headers show

Comments

Jordi Gutiérrez Hermoso - March 26, 2019, 3:57 p.m.
# HG changeset patch
# User Jordi Gutiérrez Hermoso <jordigh@octave.org>
# Date 1553615610 14400
#      Tue Mar 26 11:53:30 2019 -0400
# Node ID 5184a81a2a3b85327e15806158101acd5a685d44
# Parent  00c1ee0f746a5f427e81e6d18e681f6a70a2639d
chistedit: change in-progress message

Saying "running histedit" is an artifact of when chistedit was a
separate thing from histedit. I found the message a bit confusing,
since wasn't I running histedit from the beginning, just from the
curses interface?

The whole thing is now histedit, both the curses interface and the
underlying procedure to apply a plan, so let's use a message that
doesn't make a distinction.
Pulkit Goyal - March 27, 2019, 10:21 a.m.
On Tue, Mar 26, 2019 at 6:59 PM Jordi Gutiérrez Hermoso <jordigh@octave.org>
wrote:

> # HG changeset patch
> # User Jordi Gutiérrez Hermoso <jordigh@octave.org>
> # Date 1553615610 14400
> #      Tue Mar 26 11:53:30 2019 -0400
> # Node ID 5184a81a2a3b85327e15806158101acd5a685d44
> # Parent  00c1ee0f746a5f427e81e6d18e681f6a70a2639d
> chistedit: change in-progress message
>
> Saying "running histedit" is an artifact of when chistedit was a
> separate thing from histedit. I found the message a bit confusing,
> since wasn't I running histedit from the beginning, just from the
> curses interface?
>
> The whole thing is now histedit, both the curses interface and the
> underlying procedure to apply a plan, so let's use a message that
> doesn't make a distinction.
>

Queued this, many thanks!

Patch

diff --git a/hgext/histedit.py b/hgext/histedit.py
--- a/hgext/histedit.py
+++ b/hgext/histedit.py
@@ -1497,7 +1497,7 @@  def _chistedit(ui, repo, *freeargs, **op
             ui.write(_("histedit aborted\n"))
             return 0
         if type(rc) is list:
-            ui.status(_("running histedit\n"))
+            ui.status(_("performing changes\n"))
             rules = makecommands(rc)
             filename = repo.vfs.join('chistedit')
             with open(filename, 'w+') as fp: