Submitter | phabricator |
---|---|
Date | March 19, 2019, 1:40 p.m. |
Message ID | <differential-rev-PHID-DREV-2mck4jba564xzfubx4vj-req@phab.mercurial-scm.org> |
Download | mbox | patch |
Permalink | /patch/39333/ |
State | Superseded |
Headers | show |
Comments
> @@ -231,8 +235,10 @@ > raise ValueError( > r'node %s does not exist' % pycompat.sysstr(hex(node))) > self._entries.setdefault(label, []).append(node) > + self._verifiedbranches.add(label) Can we expect that we'll rewrite this `load()` logic to handle verification state of multiple nodes (i.e. heads) correctly? It's unclear to me how lazy verification will be implemented.
yuja added a comment. > @@ -231,8 +235,10 @@ > > raise ValueError( > r'node %s does not exist' % pycompat.sysstr(hex(node))) > self._entries.setdefault(label, []).append(node) > > + self._verifiedbranches.add(label) Can we expect that we'll rewrite this `load()` logic to handle verification state of multiple nodes (i.e. heads) correctly? It's unclear to me how lazy verification will be implemented. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6156 To: pulkit, #hg-reviewers Cc: yuja, mercurial-devel
Patch
diff --git a/mercurial/branchmap.py b/mercurial/branchmap.py --- a/mercurial/branchmap.py +++ b/mercurial/branchmap.py @@ -162,6 +162,10 @@ else: self._closednodes = closednodes self._entries = dict(entries) + # whether closed nodes are verified or not + self._closedverified = False + # branches for which nodes are verified + self._verifiedbranches = set() def __iter__(self): return iter(self._entries) @@ -231,8 +235,10 @@ raise ValueError( r'node %s does not exist' % pycompat.sysstr(hex(node))) self._entries.setdefault(label, []).append(node) + self._verifiedbranches.add(label) if state == 'c': self._closednodes.add(node) + self._closedverified = True @staticmethod def _filename(repo):