Patchwork D6123: similar: add condition to avoid Zerodivisonerror in function _score() (issue6099)

login
register
mail settings
Submitter phabricator
Date March 13, 2019, 8:17 p.m.
Message ID <e671ddefc73c8e8da7e5a17af9b24bb6@localhost.localdomain>
Download mbox | patch
Permalink /patch/39241/
State Not Applicable
Headers show

Comments

phabricator - March 13, 2019, 8:17 p.m.
akshjain.jain74 updated this revision to Diff 14487.
akshjain.jain74 retitled this revision from "ZeroDivisionError: Add condition to avoid Zerodivisonerror due to float number (issue6099)" to "similar: add condition to avoid Zerodivisonerror in function _score() (issue6099)".

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D6123?vs=14482&id=14487

REVISION DETAIL
  https://phab.mercurial-scm.org/D6123

AFFECTED FILES
  mercurial/similar.py

CHANGE DETAILS




To: akshjain.jain74, durin42, #hg-reviewers
Cc: av6, pulkit, mercurial-devel

Patch

diff --git a/mercurial/similar.py b/mercurial/similar.py
--- a/mercurial/similar.py
+++ b/mercurial/similar.py
@@ -63,7 +63,10 @@ 
             equal += len(line)
 
     lengths = len(text) + len(orig)
-    return equal * 2.0 / lengths
+    if lengths != 0:
+        return equal * 2.0 / lengths
+    else:
+        return 0
 
 def score(fctx1, fctx2):
     return _score(fctx1, _ctxdata(fctx2))