Patchwork [1,of,5,"] updatecaches: also warm revbranchcache for filtered revisions

login
register
mail settings
Submitter Pierre-Yves David
Date March 11, 2019, 9:24 a.m.
Message ID <c081522ea066709de26b.1552296240@nodosa.octopoid.net>
Download mbox | patch
Permalink /patch/39208/
State Accepted
Headers show

Comments

Pierre-Yves David - March 11, 2019, 9:24 a.m.
# HG changeset patch
# User Pierre-Yves David <pierre-yves.david@octobus.net>
# Date 1552267941 -3600
#      Mon Mar 11 02:32:21 2019 +0100
# Node ID c081522ea066709de26be0b61c5553f095b1fd6d
# Parent  e82c932c01e30121a10580e5caaeca78fec34008
# EXP-Topic fnodecache
# Available At https://bitbucket.org/octobus/mercurial-devel/
#              hg pull https://bitbucket.org/octobus/mercurial-devel/ -r c081522ea066
updatecaches: also warm revbranchcache for filtered revisions

We are in the "full" case, so we better warm everything we can.
Pulkit Goyal - March 11, 2019, 10:30 p.m.
On Mon, Mar 11, 2019 at 2:54 PM Pierre-Yves David <
pierre-yves.david@ens-lyon.org> wrote:

> # HG changeset patch
> # User Pierre-Yves David <pierre-yves.david@octobus.net>
> # Date 1552267941 -3600
> #      Mon Mar 11 02:32:21 2019 +0100
> # Node ID c081522ea066709de26be0b61c5553f095b1fd6d
> # Parent  e82c932c01e30121a10580e5caaeca78fec34008
> # EXP-Topic fnodecache
> # Available At https://bitbucket.org/octobus/mercurial-devel/
> #              hg pull https://bitbucket.org/octobus/mercurial-devel/ -r
> c081522ea066
> updatecaches: also warm revbranchcache for filtered revisions
>
> We are in the "full" case, so we better warm everything we can.
>

Queued 1 and 2. Many thanks!
Pierre-Yves David - April 26, 2019, 11:31 p.m.
On 3/11/19 11:30 PM, Pulkit Goyal wrote:
> 
> 
> On Mon, Mar 11, 2019 at 2:54 PM Pierre-Yves David 
> <pierre-yves.david@ens-lyon.org <mailto:pierre-yves.david@ens-lyon.org>> 
> wrote:
> 
>     # HG changeset patch
>     # User Pierre-Yves David <pierre-yves.david@octobus.net
>     <mailto:pierre-yves.david@octobus.net>>
>     # Date 1552267941 -3600
>     #      Mon Mar 11 02:32:21 2019 +0100
>     # Node ID c081522ea066709de26be0b61c5553f095b1fd6d
>     # Parent  e82c932c01e30121a10580e5caaeca78fec34008
>     # EXP-Topic fnodecache
>     # Available At https://bitbucket.org/octobus/mercurial-devel/
>     #              hg pull
>     https://bitbucket.org/octobus/mercurial-devel/ -r c081522ea066
>     updatecaches: also warm revbranchcache for filtered revisions
> 
>     We are in the "full" case, so we better warm everything we can.
> 
> 
> Queued 1 and 2. Many thanks!

I don't see patch 1 and 2 in the main mercurial repository. Did anything 
happened to them ?

Also: what about Patches 3-5 ?
Pulkit Goyal - April 27, 2019, 10:13 a.m.
On Sat, Apr 27, 2019 at 2:31 AM Pierre-Yves David <
pierre-yves.david@ens-lyon.org> wrote:

> On 3/11/19 11:30 PM, Pulkit Goyal wrote:
> >
> >
> > On Mon, Mar 11, 2019 at 2:54 PM Pierre-Yves David
> > <pierre-yves.david@ens-lyon.org <mailto:pierre-yves.david@ens-lyon.org>>
>
> > wrote:
> >
> >     # HG changeset patch
> >     # User Pierre-Yves David <pierre-yves.david@octobus.net
> >     <mailto:pierre-yves.david@octobus.net>>
> >     # Date 1552267941 -3600
> >     #      Mon Mar 11 02:32:21 2019 +0100
> >     # Node ID c081522ea066709de26be0b61c5553f095b1fd6d
> >     # Parent  e82c932c01e30121a10580e5caaeca78fec34008
> >     # EXP-Topic fnodecache
> >     # Available At https://bitbucket.org/octobus/mercurial-devel/
> >     #              hg pull
> >     https://bitbucket.org/octobus/mercurial-devel/ -r c081522ea066
> >     updatecaches: also warm revbranchcache for filtered revisions
> >
> >     We are in the "full" case, so we better warm everything we can.
> >
> >
> > Queued 1 and 2. Many thanks!
>
> I don't see patch 1 and 2 in the main mercurial repository. Did anything
> happened to them ?
>

I see them there as 2eee280a1354 and 481259af4bdf.

>
> Also: what about Patches 3-5 ?
>

I lost track on them. Can you send a v2?

>
>
> --
> Pierre-Yves David
>

Patch

diff --git a/mercurial/localrepo.py b/mercurial/localrepo.py
--- a/mercurial/localrepo.py
+++ b/mercurial/localrepo.py
@@ -2085,8 +2085,9 @@  class localrepository(object):
             self.filtered('served').branchmap()
 
         if full:
-            rbc = self.revbranchcache()
-            for r in self.changelog:
+            unfi = self.unfiltered()
+            rbc = unfi.revbranchcache()
+            for r in unfi.changelog:
                 rbc.branchinfo(r)
             rbc.write()