Patchwork D6110: py3: use %d instead of %s when formatting an int into a byte string

login
register
mail settings
Submitter phabricator
Date March 10, 2019, 1:50 a.m.
Message ID <ff5a3fcdd73a7673e5607134926fdf01@localhost.localdomain>
Download mbox | patch
Permalink /patch/39178/
State Not Applicable
Headers show

Comments

phabricator - March 10, 2019, 1:50 a.m.
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG634b56b54e7c: py3: use %d instead of %s when formatting an int into a byte string (authored by Kwan, committed by ).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D6110?vs=14423&id=14436

REVISION DETAIL
  https://phab.mercurial-scm.org/D6110

AFFECTED FILES
  hgext/phabricator.py

CHANGE DETAILS




To: Kwan, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/hgext/phabricator.py b/hgext/phabricator.py
--- a/hgext/phabricator.py
+++ b/hgext/phabricator.py
@@ -430,7 +430,7 @@ 
     # existing revision (revid is not None) since that introduces visible
     # churns (someone edited "Summary" twice) on the web page.
     if parentrevid and revid is None:
-        summary = b'Depends on D%s' % parentrevid
+        summary = b'Depends on D%d' % parentrevid
         transactions += [{b'type': b'summary', b'value': summary},
                          {b'type': b'summary', b'value': b' '}]
 
@@ -570,7 +570,7 @@ 
              b'skipped': _(b'skipped'),
              b'updated': _(b'updated')}[action],
             b'phabricator.action.%s' % action)
-        drevdesc = ui.label(b'D%s' % newrevid, b'phabricator.drev')
+        drevdesc = ui.label(b'D%d' % newrevid, b'phabricator.drev')
         nodedesc = ui.label(bytes(ctx), b'phabricator.node')
         desc = ui.label(ctx.description().split(b'\n')[0], b'phabricator.desc')
         ui.write(_(b'%s - %s - %s: %s\n') % (drevdesc, actiondesc, nodedesc,