Patchwork [10,of,18,"] verify: document the `checkentry` method

login
register
mail settings
Submitter Pulkit Goyal
Date March 6, 2019, 6:16 p.m.
Message ID <CAJ-kjL-Nge5gPiT-dKkxkC1278ssQf=CGTtB9ki4S55k5d71Fw@mail.gmail.com>
Download mbox | patch
Permalink /patch/39111/
State New
Headers show

Comments

Pulkit Goyal - March 6, 2019, 6:16 p.m.
On Wed, Mar 6, 2019 at 8:03 PM Pierre-Yves David <
pierre-yves.david@ens-lyon.org> wrote:

> # HG changeset patch
> # User Pierre-Yves David <pierre-yves.david@octobus.net>
> # Date 1551871084 -3600
> #      Wed Mar 06 12:18:04 2019 +0100
> # Node ID 51efb7d6f032202abaeaed8bf1b3a13a9f426cdd
> # Parent  8092d6de83c346e069322eede70baa05896744d3
> # EXP-Topic verify
> # Available At https://bitbucket.org/octobus/mercurial-devel/
> #              hg pull https://bitbucket.org/octobus/mercurial-devel/ -r
> 51efb7d6f032
> verify: document the `checkentry` method
>
> This method checks various core propertes of a revision. We document
> inputs, outputs
> and the checks performed.
>

Amending the following diff in flight:

```

Performs the following checks:
```

Patch

diff --git a/mercurial/verify.py b/mercurial/verify.py
--- a/mercurial/verify.py
+++ b/mercurial/verify.py
@@ -99,9 +99,9 @@  class verifier(object):
         arguments are:
         - obj:      the source revlog
         - i:        the revision number
-        - n:        the revision node id
+        - node:        the revision node id
         - seen:     nodes previously seen for this revlog
-        - linkrevs: [changelog-revisions] introducing "n"
+        - linkrevs: [changelog-revisions] introducing "node"
         - f:        string label ("changelog", "manifest", or filename)