Patchwork D6068: inno: remove w9xpopen.exe

login
register
mail settings
Submitter phabricator
Date March 4, 2019, 2:22 a.m.
Message ID <differential-rev-PHID-DREV-cujihiftnbo26gfzxqgd-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/39040/
State Superseded
Headers show

Comments

phabricator - March 4, 2019, 2:22 a.m.
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  w9xpopen.exe is a utility program shipped with Python <3.4
  (https://bugs.python.org/issue14470 tracked its removal).
  
  The program was used by subprocess to wrap invoked processes
  on Windows 95 and 98 or when command.com was used in order to
  work around a redirect bug.
  
  The workaround is only used on ancient Windows versions -
  versions that we shouldn't see in 2019.
  
  While Python 2.7's subprocess module still references
  w9xpopen.exe, not shipping it shouldn't matter unless we're
  running an ancient version of Windows. Python will raise
  an exception if w9xpopen.exe can't be found.
  
  It's highly unlikely anyone is using current Mercurial releases
  on these ancient Windows versions. So remove w9xpopen.exe
  from the Inno installer.
  
  .. bc::
  
    The 32-bit Windows Inno installers no longer distribute
    w9xpopen.exe. This should only impact people running
    Mercurial on Windows 95, 98, or ME.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6068

AFFECTED FILES
  contrib/packaging/inno/mercurial.iss

CHANGE DETAILS




To: indygreg, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/contrib/packaging/inno/mercurial.iss b/contrib/packaging/inno/mercurial.iss
--- a/contrib/packaging/inno/mercurial.iss
+++ b/contrib/packaging/inno/mercurial.iss
@@ -74,8 +74,6 @@ 
 #if ARCH == "x64"
 Source: dist\lib\*.dll; Destdir: {app}\lib
 Source: dist\lib\*.pyd; Destdir: {app}\lib
-#else
-Source: dist\w9xpopen.exe; DestDir: {app}
 #endif
 Source: dist\python*.dll; Destdir: {app}; Flags: skipifsourcedoesntexist
 Source: dist\msvc*.dll; DestDir: {app}; Flags: skipifsourcedoesntexist