Patchwork D5955: watchman: ignore some of watchman errors

login
register
mail settings
Submitter phabricator
Date Feb. 13, 2019, 4:22 p.m.
Message ID <differential-rev-PHID-DREV-g6wgtw4aviv7mau44syt-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/38729/
State Superseded
Headers show

Comments

phabricator - Feb. 13, 2019, 4:22 p.m.
lothiraldan created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  Don't display 'illegal_fstypes' errors. In environments with network
  filesystems, the error messages are quickly pilling up and polluting outputs.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5955

AFFECTED FILES
  hgext/fsmonitor/__init__.py

CHANGE DETAILS




To: lothiraldan, #hg-reviewers
Cc: mercurial-devel
phabricator - Feb. 20, 2019, 9:38 a.m.
lothiraldan added a subscriber: indygreg.
lothiraldan added a comment.


  @indygreg I've update the patchs with your reviews.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5955

To: lothiraldan, #hg-reviewers
Cc: indygreg, mercurial-devel
phabricator - Feb. 27, 2019, 9:47 a.m.
lothiraldan added a comment.


  Gentle ping on this series

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5955

To: lothiraldan, #hg-reviewers
Cc: indygreg, mercurial-devel

Patch

diff --git a/hgext/fsmonitor/__init__.py b/hgext/fsmonitor/__init__.py
--- a/hgext/fsmonitor/__init__.py
+++ b/hgext/fsmonitor/__init__.py
@@ -180,7 +180,8 @@ 
     if isinstance(ex, watchmanclient.Unavailable):
         # experimental config: fsmonitor.verbose
         if ex.warn and ui.configbool('fsmonitor', 'verbose'):
-            ui.warn(str(ex) + '\n')
+            if 'illegal_fstypes' not in str(ex):
+                ui.warn(str(ex) + '\n')
         if ex.invalidate:
             state.invalidate()
         # experimental config: fsmonitor.verbose