Patchwork [01,of,11,RFC] tests: modify existing tests to support x, exec

login
register
mail settings
Submitter Olle Lundberg
Date March 5, 2014, 4:15 p.m.
Message ID <fbf918233ab1c75d2b8c.1394036112@SE-C02KQ0DADR55>
Download mbox | patch
Permalink /patch/3852/
State Changes Requested
Headers show

Comments

Olle Lundberg - March 5, 2014, 4:15 p.m.
# HG changeset patch
# User Olle Lundberg <geek@nerd.sh>
# Date 1393889478 -3600
#      Tue Mar 04 00:31:18 2014 +0100
# Node ID fbf918233ab1c75d2b8ca0fd3f6bc4a0033f521c
# Parent  779ceb84f4f782d32dfe47f6684107c08d2f6142
tests: modify existing tests to support x, exec
Mads Kiilerich - March 5, 2014, 5:39 p.m.
On 03/05/2014 05:15 PM, Olle Lundberg wrote:
> # HG changeset patch
> # User Olle Lundberg <geek@nerd.sh>
> # Date 1393889478 -3600
> #      Tue Mar 04 00:31:18 2014 +0100
> # Node ID fbf918233ab1c75d2b8ca0fd3f6bc4a0033f521c
> # Parent  779ceb84f4f782d32dfe47f6684107c08d2f6142
> tests: modify existing tests to support x, exec

The whole test suite should pass after each change. It looks like this 
change should be a part of patch 2 where the help text actually is updated?

It looks like other of the patches have similar issues.

It also looks like patch 2 adds documentation for command option that 
only is added in patch 6? If it still makes sense to keep the built-in 
documentation separate from the implementation, then I think it would be 
better to first introduce an undocumented feature and then document it 
later.

/Mads
Olle Lundberg - March 5, 2014, 5:48 p.m.
On Wed, Mar 5, 2014 at 6:39 PM, Mads Kiilerich <mads@kiilerich.com> wrote:

> On 03/05/2014 05:15 PM, Olle Lundberg wrote:
>
>> # HG changeset patch
>> # User Olle Lundberg <geek@nerd.sh>
>> # Date 1393889478 -3600
>> #      Tue Mar 04 00:31:18 2014 +0100
>> # Node ID fbf918233ab1c75d2b8ca0fd3f6bc4a0033f521c
>> # Parent  779ceb84f4f782d32dfe47f6684107c08d2f6142
>> tests: modify existing tests to support x, exec
>>
>
> The whole test suite should pass after each change. It looks like this
> change should be a part of patch 2 where the help text actually is updated?
>

True, not used to sending bigger patch sets to mercurial.
Will wait for more feedback and rework the patches.

The patches should be able to apply with out the other, but I will fold and
reorder according to what you said.


>
> It looks like other of the patches have similar issues.
>
> It also looks like patch 2 adds documentation for command option that only
> is added in patch 6? If it still makes sense to keep the built-in
> documentation separate from the implementation, then I think it would be
> better to first introduce an undocumented feature and then document it
> later.
>
> /Mads
>
>

Patch

diff --git a/tests/test-histedit-arguments.t b/tests/test-histedit-arguments.t
--- a/tests/test-histedit-arguments.t
+++ b/tests/test-histedit-arguments.t
@@ -57,10 +57,11 @@ 
   #  p, pick = use commit
   #  e, edit = use commit, but stop for amending
   #  f, fold = use commit, but combine it with the one above
   #  d, drop = remove commit from history
   #  m, mess = edit message without changing commit content
+  #  x, exec = execute the given command
   #
   0 files updated, 0 files merged, 0 files removed, 0 files unresolved
 
 Run on a revision not ancestors of the current working directory.
 --------------------------------------------------------------------
diff --git a/tests/test-histedit-bookmark-motion.t b/tests/test-histedit-bookmark-motion.t
--- a/tests/test-histedit-bookmark-motion.t
+++ b/tests/test-histedit-bookmark-motion.t
@@ -73,10 +73,11 @@ 
   #  p, pick = use commit
   #  e, edit = use commit, but stop for amending
   #  f, fold = use commit, but combine it with the one above
   #  d, drop = remove commit from history
   #  m, mess = edit message without changing commit content
+  #  x, exec = execute the given command
   #
   0 files updated, 0 files merged, 0 files removed, 0 files unresolved
   $ hg histedit 1 --commands - --verbose << EOF | grep histedit
   > pick 177f92b77385 2 c
   > drop d2ae7f538514 1 b
@@ -133,10 +134,11 @@ 
   #  p, pick = use commit
   #  e, edit = use commit, but stop for amending
   #  f, fold = use commit, but combine it with the one above
   #  d, drop = remove commit from history
   #  m, mess = edit message without changing commit content
+  #  x, exec = execute the given command
   #
   0 files updated, 0 files merged, 0 files removed, 0 files unresolved
   $ hg histedit 1 --commands - --verbose << EOF | grep histedit
   > pick b346ab9a313d 1 c
   > pick cacdfd884a93 3 f
diff --git a/tests/test-histedit-commute.t b/tests/test-histedit-commute.t
--- a/tests/test-histedit-commute.t
+++ b/tests/test-histedit-commute.t
@@ -67,10 +67,11 @@ 
   #  p, pick = use commit
   #  e, edit = use commit, but stop for amending
   #  f, fold = use commit, but combine it with the one above
   #  d, drop = remove commit from history
   #  m, mess = edit message without changing commit content
+  #  x, exec = execute the given command
   #
   0 files updated, 0 files merged, 0 files removed, 0 files unresolved
 
 edit the history
 (use a hacky editor to check histedit-last-edit.txt backup)
diff --git a/tests/test-histedit-obsolete.t b/tests/test-histedit-obsolete.t
--- a/tests/test-histedit-obsolete.t
+++ b/tests/test-histedit-obsolete.t
@@ -57,10 +57,11 @@ 
   #  p, pick = use commit
   #  e, edit = use commit, but stop for amending
   #  f, fold = use commit, but combine it with the one above
   #  d, drop = remove commit from history
   #  m, mess = edit message without changing commit content
+  #  x, exec = execute the given command
   #
   0 files updated, 0 files merged, 0 files removed, 0 files unresolved
   $ hg histedit 1 --commands - --verbose <<EOF | grep histedit
   > pick 177f92b77385 2 c
   > drop d2ae7f538514 1 b
diff --git a/tests/test-histedit-outgoing.t b/tests/test-histedit-outgoing.t
--- a/tests/test-histedit-outgoing.t
+++ b/tests/test-histedit-outgoing.t
@@ -49,10 +49,11 @@ 
   #  p, pick = use commit
   #  e, edit = use commit, but stop for amending
   #  f, fold = use commit, but combine it with the one above
   #  d, drop = remove commit from history
   #  m, mess = edit message without changing commit content
+  #  x, exec = execute the given command
   #
   0 files updated, 0 files merged, 0 files removed, 0 files unresolved
   $ cd ..
 
 show the error from unrelated repos
@@ -80,10 +81,11 @@ 
   #  p, pick = use commit
   #  e, edit = use commit, but stop for amending
   #  f, fold = use commit, but combine it with the one above
   #  d, drop = remove commit from history
   #  m, mess = edit message without changing commit content
+  #  x, exec = execute the given command
   #
   0 files updated, 0 files merged, 0 files removed, 0 files unresolved
   $ cd ..
 
 test sensitivity to branch in URL:
@@ -103,10 +105,11 @@ 
   #  p, pick = use commit
   #  e, edit = use commit, but stop for amending
   #  f, fold = use commit, but combine it with the one above
   #  d, drop = remove commit from history
   #  m, mess = edit message without changing commit content
+  #  x, exec = execute the given command
   #
   0 files updated, 0 files merged, 0 files removed, 0 files unresolved
 
 test to check number of roots in outgoing revisions