Patchwork [2,of,6] run-tests: allow spaces in the --view tool

login
register
mail settings
Submitter Matt Harbison
Date Feb. 6, 2019, 2:35 a.m.
Message ID <4bad819762856a2a6b5c.1549420545@Envy>
Download mbox | patch
Permalink /patch/38469/
State Accepted
Headers show

Comments

Matt Harbison - Feb. 6, 2019, 2:35 a.m.
# HG changeset patch
# User Matt Harbison <matt_harbison@yahoo.com>
# Date 1549391448 18000
#      Tue Feb 05 13:30:48 2019 -0500
# Node ID 4bad819762856a2a6b5c9faeb52a15fa63b1ca9e
# Parent  e68578660449146a4b77089e8419542a61a3dc1c
run-tests: allow spaces in the --view tool

Most tools on Windows are in Program Files, and not necessarily on PATH.

Patch

diff --git a/tests/run-tests.py b/tests/run-tests.py
--- a/tests/run-tests.py
+++ b/tests/run-tests.py
@@ -1902,8 +1902,9 @@  class TestResult(unittest._TextTestResul
                 pass
             elif self._options.view:
                 v = self._options.view
-                os.system(r"%s %s %s" %
-                          (v, _strpath(test.refpath), _strpath(test.errpath)))
+                subprocess.call(r'"%s" "%s" "%s"' %
+                                (v, _strpath(test.refpath),
+                                _strpath(test.errpath)), shell=True)
             else:
                 servefail, lines = getdiff(expected, got,
                                            test.refpath, test.errpath)