Patchwork D5794: py3: pass str into grp.getgrnam

login
register
mail settings
Submitter phabricator
Date Feb. 2, 2019, 12:51 a.m.
Message ID <cfb5e91dfad3a5d9e96fafef529622d3@localhost.localdomain>
Download mbox | patch
Permalink /patch/38307/
State Not Applicable
Headers show

Comments

phabricator - Feb. 2, 2019, 12:51 a.m.
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGe011c78da629: py3: pass str into grp.getgrnam (authored by pulkit, committed by ).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D5794?vs=13678&id=13683

REVISION DETAIL
  https://phab.mercurial-scm.org/D5794

AFFECTED FILES
  contrib/python3-whitelist
  mercurial/posix.py

CHANGE DETAILS




To: pulkit, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/mercurial/posix.py b/mercurial/posix.py
--- a/mercurial/posix.py
+++ b/mercurial/posix.py
@@ -583,6 +583,7 @@ 
     """Return the list of members of the group with the given
     name, KeyError if the group does not exist.
     """
+    name = pycompat.sysstr(name)
     return list(grp.getgrnam(name).gr_mem)
 
 def spawndetached(args):
diff --git a/contrib/python3-whitelist b/contrib/python3-whitelist
--- a/contrib/python3-whitelist
+++ b/contrib/python3-whitelist
@@ -5,6 +5,7 @@ 
 test-absorb-rename.t
 test-absorb-strip.t
 test-absorb.t
+test-acl.t
 test-add.t
 test-addremove-similar.t
 test-addremove.t