Patchwork D5739: montone: fix addition to list by using .append() instead of '+'

login
register
mail settings
Submitter phabricator
Date Feb. 1, 2019, 11:31 p.m.
Message ID <4cac11eeb148fe284cc83cfb1e906ff9@localhost.localdomain>
Download mbox | patch
Permalink /patch/38301/
State Not Applicable
Headers show

Comments

phabricator - Feb. 1, 2019, 11:31 p.m.
pulkit updated this revision to Diff 13677.
pulkit retitled this revision from "py3: use pycompat.bytestr() so that slicing does not result in ascii values" to "montone: fix addition to list by using .append() instead of '+'".

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D5739?vs=13561&id=13677

REVISION DETAIL
  https://phab.mercurial-scm.org/D5739

AFFECTED FILES
  hgext/convert/monotone.py

CHANGE DETAILS




To: pulkit, #hg-reviewers
Cc: yuja, mercurial-devel

Patch

diff --git a/hgext/convert/monotone.py b/hgext/convert/monotone.py
--- a/hgext/convert/monotone.py
+++ b/hgext/convert/monotone.py
@@ -102,7 +102,7 @@ 
 
         command.append('l')
         for arg in args:
-            command += "%d:%s" % (len(arg), arg)
+            command.append("%d:%s" % (len(arg), arg))
         command.append('e')
         command = ''.join(command)