Patchwork [1,of,2] py3: byteify the --retest path of run-tests.py

login
register
mail settings
Submitter Matt Harbison
Date Feb. 1, 2019, 3:07 a.m.
Message ID <d3dc4abc547aca55e1de.1548990470@Envy>
Download mbox | patch
Permalink /patch/38284/
State Accepted
Headers show

Comments

Matt Harbison - Feb. 1, 2019, 3:07 a.m.
# HG changeset patch
# User Matt Harbison <matt_harbison@yahoo.com>
# Date 1548989678 18000
#      Thu Jan 31 21:54:38 2019 -0500
# Node ID d3dc4abc547aca55e1de6b89ff59e86e635d5ec8
# Parent  fe2c826533a7285a38d536b532e0068ca4fb64e1
py3: byteify the --retest path of run-tests.py
Pulkit Goyal - Feb. 1, 2019, 11:24 a.m.
On Fri, Feb 1, 2019 at 6:09 AM Matt Harbison <mharbison72@gmail.com> wrote:

> # HG changeset patch
> # User Matt Harbison <matt_harbison@yahoo.com>
> # Date 1548989678 18000
> #      Thu Jan 31 21:54:38 2019 -0500
> # Node ID d3dc4abc547aca55e1de6b89ff59e86e635d5ec8
> # Parent  fe2c826533a7285a38d536b532e0068ca4fb64e1
> py3: byteify the --retest path of run-tests.py
>

Queued the series, many thanks!

Patch

diff --git a/tests/run-tests.py b/tests/run-tests.py
--- a/tests/run-tests.py
+++ b/tests/run-tests.py
@@ -2772,8 +2772,8 @@  class TestRunner(object):
         """
         if not args:
             if self.options.changed:
-                proc = Popen4('hg st --rev "%s" -man0 .' %
-                              self.options.changed, None, 0)
+                proc = Popen4(b'hg st --rev "%s" -man0 .' %
+                              _bytespath(self.options.changed), None, 0)
                 stdout, stderr = proc.communicate()
                 args = stdout.strip(b'\0').split(b'\0')
             else: