Patchwork test-lock-badness.t sometimes fails

login
register
mail settings
Submitter Simon Heimberg
Date March 1, 2014, 10:58 a.m.
Message ID <5311BD6D.6060206@besonet.ch>
Download mbox | patch
Permalink /patch/3812/
State Not Applicable
Headers show

Comments

Simon Heimberg - March 1, 2014, 10:58 a.m.
The test fails sometimes because the machine is a bit too slow.

I am not sure if we shouldmatch generally  or on 1 and 2 only (but not 0):
  got lock after ? seconds (glob)
or
  got lock after [12] seconds (re)


introduced in [1]


[1] http://hg.intevation.org/mercurial/rev/c697b70f295f
[2] http://hgbuildbot.kublai.com/builders/OS%20X%2010.8%20hg%20tests/builds/131/steps/pure/logs/stdio
Matt Mackall - March 3, 2014, 6:25 p.m.
On Sat, 2014-03-01 at 11:58 +0100, Simon Heimberg wrote:
> The test fails sometimes because the machine is a bit too slow.
> 
> I am not sure if we shouldmatch generally  or on 1 and 2 only (but not 0):
>   got lock after ? seconds (glob)

I'd go as far as *.

Patch

=================
c697b70f295f:
localrepo: give a sigh of relief when getting lock after waiting for it
by: Mads

Failure [2]
===========
--- /Users/buildslave/mountainlion/OS_X_10_8_hg_tests/build/tests/test-lock-badness.t
+++ /Users/buildslave/mountainlion/OS_X_10_8_hg_tests/build/tests/test-lock-badness.t.err
@@ -22,7 +22,7 @@ 
    $ hg -R b ci -A -m b --config hooks.precommit="python:`pwd`/hooks.py:sleepone" > stdout &
    $ hg -R b up -q --config hooks.pre-update="python:`pwd`/hooks.py:sleephalf"
    waiting for lock on working directory of b held by '*:*' (glob)
-  got lock after 1 seconds
+  got lock after 2 seconds
    warning: ignoring unknown working parent d2ae7f538514!
    $ wait
    $ cat stdout