Patchwork [2,of,2,BACKOUT] mmap: backed out changeset 875d2af8cb4e

login
register
mail settings
Submitter Boris Feld
Date Jan. 18, 2019, 3:26 p.m.
Message ID <c25539844f6594804423.1547825166@localhost.localdomain>
Download mbox | patch
Permalink /patch/37874/
State Accepted
Headers show

Comments

Boris Feld - Jan. 18, 2019, 3:26 p.m.
# HG changeset patch
# User Boris Feld <boris.feld@octobus.net>
# Date 1547823817 -3600
#      Fri Jan 18 16:03:37 2019 +0100
# Node ID c25539844f6594804423565712959afc190c56d9
# Parent  452fc7c6bf18316b98d50789aef6fd744d04b47f
# EXP-Topic mmap
# Available At https://bitbucket.org/octobus/mercurial-devel/
#              hg pull https://bitbucket.org/octobus/mercurial-devel/ -r c25539844f65
mmap: backed out changeset 875d2af8cb4e

There have been concrete and theoretical issues raised, this will need more
work during the next cycle.

Patch

diff --git a/mercurial/configitems.py b/mercurial/configitems.py
--- a/mercurial/configitems.py
+++ b/mercurial/configitems.py
@@ -556,6 +556,9 @@  coreconfigitem('experimental', 'maxdelta
 coreconfigitem('experimental', 'mergetempdirprefix',
     default=None,
 )
+coreconfigitem('experimental', 'mmapindexthreshold',
+    default=None,
+)
 coreconfigitem('experimental', 'narrow',
     default=False,
 )
@@ -987,10 +990,6 @@  coreconfigitem('progress', 'width',
 coreconfigitem('push', 'pushvars.server',
     default=False,
 )
-coreconfigitem('storage', 'mmap-threshold',
-    default=None,
-    alias=[('experimental', 'mmapindexthreshold')],
-)
 coreconfigitem('rewrite', 'backup-bundle',
     default=True,
     alias=[('ui', 'history-editing-backup')],
diff --git a/mercurial/localrepo.py b/mercurial/localrepo.py
--- a/mercurial/localrepo.py
+++ b/mercurial/localrepo.py
@@ -758,7 +758,8 @@  def resolverevlogstorevfsoptions(ui, req
     if 0 <= chainspan:
         options[b'maxdeltachainspan'] = chainspan
 
-    mmapindexthreshold = ui.configbytes(b'storage', b'mmap-threshold')
+    mmapindexthreshold = ui.configbytes(b'experimental',
+                                        b'mmapindexthreshold')
     if mmapindexthreshold is not None:
         options[b'mmapindexthreshold'] = mmapindexthreshold