Patchwork coal: hgweb style adds extra blank line in file view (issue4136)

login
register
mail settings
Submitter Anurag Goel
Date Feb. 27, 2014, 6:01 p.m.
Message ID <18e1e3bebef8d5387e51.1393524099@ubuntu.ubuntu-domain>
Download mbox | patch
Permalink /patch/3785/
State Accepted
Commit de48422df393bbf80dcd5d4f9571e48663452d86
Headers show

Comments

Anurag Goel - Feb. 27, 2014, 6:01 p.m.
# HG changeset patch
# User anuraggoel <anurag.dsps@gmail.com>
# Date 1393522002 -19800
#      Thu Feb 27 22:56:42 2014 +0530
# Node ID 18e1e3bebef8d5387e514d05df8eb3ccaa5ae5b2
# Parent  a9565edbbdf1fdda28b218e478d7c714f46c4e97
coal: hgweb style adds extra blank line in file view (issue4136)

Now hgweb style='coal' adds no extra blank in file view.
Matt Mackall - Feb. 27, 2014, 7:32 p.m.
On Thu, 2014-02-27 at 23:31 +0530, Anurag Goel wrote:
> # HG changeset patch
> # User anuraggoel <anurag.dsps@gmail.com>
> # Date 1393522002 -19800
> #      Thu Feb 27 22:56:42 2014 +0530
> # Node ID 18e1e3bebef8d5387e514d05df8eb3ccaa5ae5b2
> # Parent  a9565edbbdf1fdda28b218e478d7c714f46c4e97
> coal: hgweb style adds extra blank line in file view (issue4136)
> 
> Now hgweb style='coal' adds no extra blank in file view.

Excellent, queued for stable. For future reference, you should use 'hg
email --flag stable' for things that are appropriate for the stable
branch. See:

http://mercurial.selenic.com/wiki/TimeBasedReleasePlan#Rules_for_code_freeze_and_stable_branch_commits

Patch

diff -r a9565edbbdf1 -r 18e1e3bebef8 mercurial/templates/static/style-coal.css
--- a/mercurial/templates/static/style-coal.css	Thu Feb 27 22:47:16 2014 +0530
+++ b/mercurial/templates/static/style-coal.css	Thu Feb 27 22:56:42 2014 +0530
@@ -214,6 +214,13 @@ 
 .source a { color: #999; font-size: smaller; font-family: monospace;}
 .bottomline { border-bottom: 1px solid #999; }
 
+.sourcelines > div {
+  display: inline-block;
+  width: 100%;
+  padding: 1px 0px;
+  counter-increment: lineno;
+}
+
 .fileline { font-family: monospace; }
 .fileline img { border: 0; }