Patchwork D5598: basepack: avoid 'rbe' mode in Python 3

login
register
mail settings
Submitter phabricator
Date Jan. 16, 2019, 5:21 p.m.
Message ID <9a96b6271b8c99da1a1f04dde1127658@localhost.localdomain>
Download mbox | patch
Permalink /patch/37817/
State Not Applicable
Headers show

Comments

phabricator - Jan. 16, 2019, 5:21 p.m.
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGc891a11ffe27: basepack: avoid &#039;rbe&#039; mode in Python 3 (authored by durin42, committed by ).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D5598?vs=13258&id=13279

REVISION DETAIL
  https://phab.mercurial-scm.org/D5598

AFFECTED FILES
  hgext/remotefilelog/basepack.py

CHANGE DETAILS




To: durin42, #hg-reviewers, pulkit
Cc: mjpieters, mercurial-devel

Patch

diff --git a/hgext/remotefilelog/basepack.py b/hgext/remotefilelog/basepack.py
--- a/hgext/remotefilelog/basepack.py
+++ b/hgext/remotefilelog/basepack.py
@@ -52,9 +52,10 @@ 
 # loaded the pack list.
 REFRESHRATE = 0.1
 
-if pycompat.isposix:
+if pycompat.isposix and not pycompat.ispy3:
     # With glibc 2.7+ the 'e' flag uses O_CLOEXEC when opening.
     # The 'e' flag will be ignored on older versions of glibc.
+    # Python 3 can't handle the 'e' flag.
     PACKOPENMODE = 'rbe'
 else:
     PACKOPENMODE = 'rb'