Patchwork D5507: narrow: drop now-unnecessary reassignment of repo attributes

login
register
mail settings
Submitter phabricator
Date Jan. 16, 2019, 9:34 a.m.
Message ID <c039417f944ad697ab6cece5688c397d@localhost.localdomain>
Download mbox | patch
Permalink /patch/37785/
State Not Applicable
Headers show

Comments

phabricator - Jan. 16, 2019, 9:34 a.m.
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGa2ae27993e16: narrow: drop now-unnecessary reassignment of repo attributes (authored by martinvonz, committed by ).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D5507?vs=13147&id=13245

REVISION DETAIL
  https://phab.mercurial-scm.org/D5507

AFFECTED FILES
  mercurial/localrepo.py

CHANGE DETAILS




To: martinvonz, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/mercurial/localrepo.py b/mercurial/localrepo.py
--- a/mercurial/localrepo.py
+++ b/mercurial/localrepo.py
@@ -1261,12 +1261,6 @@ 
         narrowspec.save(self, newincludes, newexcludes)
         narrowspec.copytoworkingcopy(self)
         self.invalidate(clearfilecache=True)
-        # So the next access won't be considered a conflict
-        # TODO: It seems like there should be a way of doing this that
-        # doesn't involve replacing these attributes.
-        self.narrowpats = newincludes, newexcludes
-        self._narrowmatch = narrowspec.match(self.root, include=newincludes,
-                                             exclude=newexcludes)
 
     def __getitem__(self, changeid):
         if changeid is None: