Patchwork [08,of,18,V2] localrepo: drop `_cacheabletip` method

login
register
mail settings
Submitter Pierre-Yves David
Date Jan. 4, 2013, 1:04 a.m.
Message ID <f33473072cb625b64b9d.1357261451@yamac.lan>
Download mbox | patch
Permalink /patch/377/
State Accepted
Commit c565761dde6aa1a70b688cd2eebad69e9b5a16db
Headers show

Comments

Pierre-Yves David - Jan. 4, 2013, 1:04 a.m.
# HG changeset patch
# User Pierre-Yves David <pierre-yves.david at ens-lyon.org>
# Date 1357259858 -3600
# Node ID f33473072cb625b64b9ded2d4eb054f42c735a6c
# Parent  4e5577b9b1c9e3582e7cf362cce5d3a7d454f821
localrepo: drop `_cacheabletip` method

It iss dead code now.
Kevin Bullock - Jan. 4, 2013, 4:47 a.m.
On 3 Jan 2013, at 7:04 PM, Pierre-Yves David wrote:

> # HG changeset patch
> # User Pierre-Yves David <pierre-yves.david at ens-lyon.org>
> # Date 1357259858 -3600
> # Node ID f33473072cb625b64b9ded2d4eb054f42c735a6c
> # Parent  4e5577b9b1c9e3582e7cf362cce5d3a7d454f821
> localrepo: drop `_cacheabletip` method

Pushed 1 thru 8 to crew as c565761dde6a.

pacem in terris / ??? / ?????? / ????????? / ??
Kevin R. Bullock

Patch

diff --git a/mercurial/localrepo.py b/mercurial/localrepo.py
--- a/mercurial/localrepo.py
+++ b/mercurial/localrepo.py
@@ -648,22 +648,10 @@  class localrepository(object):
         for bookmark, n in self._bookmarks.iteritems():
             if n == node:
                 marks.append(bookmark)
         return sorted(marks)
 
-    def _cacheabletip(self):
-        """tip-most revision stable enought to used in persistent cache
-
-        This function is overwritten by MQ to ensure we do not write cache for
-        a part of the history that will likely change.
-
-        Efficient handling of filtered revision in branchcache should offer a
-        better alternative. But we are using this approach until it is ready.
-        """
-        cl = self.changelog
-        return cl.rev(cl.tip())
-
     def branchmap(self):
         '''returns a dictionary {branch: [branchheads]}'''
         if self.filtername and not self.changelog.filteredrevs:
             return self.unfiltered().branchmap()
         branchmap.updatecache(self)