Patchwork exthelper: drop a compatibility shim with '^command' syntax

login
register
mail settings
Submitter Matt Harbison
Date Dec. 27, 2018, 6:43 a.m.
Message ID <0fd3f0947fbea9ff60c8.1545893015@Envy>
Download mbox | patch
Permalink /patch/37360/
State Accepted
Headers show

Comments

Matt Harbison - Dec. 27, 2018, 6:43 a.m.
# HG changeset patch
# User Matt Harbison <matt_harbison@yahoo.com>
# Date 1545887440 18000
#      Thu Dec 27 00:10:40 2018 -0500
# Node ID 0fd3f0947fbea9ff60c8fc447d751bf653d70303
# Parent  32aa43e038570b844946896376b358cada94f972
exthelper: drop a compatibility shim with '^command' syntax

This syntax was dropped in fa88170c10bb.
Yuya Nishihara - Dec. 27, 2018, 11:25 a.m.
On Thu, 27 Dec 2018 01:43:35 -0500, Matt Harbison wrote:
> # HG changeset patch
> # User Matt Harbison <matt_harbison@yahoo.com>
> # Date 1545887440 18000
> #      Thu Dec 27 00:10:40 2018 -0500
> # Node ID 0fd3f0947fbea9ff60c8fc447d751bf653d70303
> # Parent  32aa43e038570b844946896376b358cada94f972
> exthelper: drop a compatibility shim with '^command' syntax

Queued, thanks.

Patch

diff --git a/mercurial/exthelper.py b/mercurial/exthelper.py
--- a/mercurial/exthelper.py
+++ b/mercurial/exthelper.py
@@ -38,15 +38,6 @@  class exthelper(object):
         self._duckpunchers = []
         self.cmdtable = {}
         self.command = registrar.command(self.cmdtable)
-        if '^init' in commands.table:
-            olddoregister = self.command._doregister
-
-            def _newdoregister(self, name, *args, **kwargs):
-                if kwargs.pop('helpbasic', False):
-                    name = '^' + name
-                return olddoregister(self, name, *args, **kwargs)
-            self.command._doregister = _newdoregister
-
         self.configtable = {}
         self.configitem = registrar.configitem(self.configtable)