Patchwork D5408: progress: avoid ui.configbool() lookup when progress bar is active

login
register
mail settings
Submitter phabricator
Date Dec. 26, 2018, 5:06 p.m.
Message ID <9843d2b822b25051e49d8c62cea7693a@localhost.localdomain>
Download mbox | patch
Permalink /patch/37353/
State Not Applicable
Headers show

Comments

phabricator - Dec. 26, 2018, 5:06 p.m.
pulkit updated this revision to Diff 12982.
pulkit edited the summary of this revision.
pulkit retitled this revision from "progress: [RFC] avoid ui.configbool() lookup when progress bar is active" to "progress: avoid ui.configbool() lookup when progress bar is active".

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D5408?vs=12813&id=12982

REVISION DETAIL
  https://phab.mercurial-scm.org/D5408

AFFECTED FILES
  mercurial/progress.py
  mercurial/ui.py

CHANGE DETAILS




To: indygreg, #hg-reviewers
Cc: yuja, pulkit, mercurial-devel

Patch

diff --git a/mercurial/ui.py b/mercurial/ui.py
--- a/mercurial/ui.py
+++ b/mercurial/ui.py
@@ -1702,6 +1702,14 @@ 
         elif self._progbar is not None:
             self._progbar.progress(topic, pos, item=item, unit=unit,
                                    total=total)
+
+            # Looking up progress.debug in tight loops is expensive. The value
+            # is cached on the progbar object and we can avoid the lookup in
+            # the common case where a progbar is active.
+            if pos is None or not self._progbar.debug:
+                return
+
+        # Keep this logic in sync with above.
         if pos is None or not self.configbool('progress', 'debug'):
             return
 
diff --git a/mercurial/progress.py b/mercurial/progress.py
--- a/mercurial/progress.py
+++ b/mercurial/progress.py
@@ -104,6 +104,8 @@ 
         self.order = self.ui.configlist('progress', 'format')
         self.estimateinterval = self.ui.configwith(
             float, 'progress', 'estimateinterval')
+        # developer config: progress.debug
+        self.debug = self.ui.configbool('progress', 'debug')
 
     def show(self, now, topic, pos, item, unit, total):
         if not shouldprint(self.ui):