Patchwork [evolve-ext] exthelper: remove '_' in final_xxx() function names to conform to hg style

login
register
mail settings
Submitter Matt Harbison
Date Dec. 22, 2018, 6:44 a.m.
Message ID <0252c830b4d7c2773417.1545461092@Envy>
Download mbox | patch
Permalink /patch/37310/
State Accepted
Headers show

Comments

Matt Harbison - Dec. 22, 2018, 6:44 a.m.
# HG changeset patch
# User Matt Harbison <matt_harbison@yahoo.com>
# Date 1545460199 18000
#      Sat Dec 22 01:29:59 2018 -0500
# Node ID 0252c830b4d7c277341772c80566ec395c6aebf2
# Parent  980565468003bd66d782fde6d4128476e407dc48
exthelper: remove '_' in final_xxx() function names to conform to hg style
Boris Feld - Dec. 27, 2018, 1:23 p.m.
Pushed thanks.

On 22/12/2018 07:44, Matt Harbison wrote:
> # HG changeset patch
> # User Matt Harbison <matt_harbison@yahoo.com>
> # Date 1545460199 18000
> #      Sat Dec 22 01:29:59 2018 -0500
> # Node ID 0252c830b4d7c277341772c80566ec395c6aebf2
> # Parent  980565468003bd66d782fde6d4128476e407dc48
> exthelper: remove '_' in final_xxx() function names to conform to hg style
>
> diff --git a/hgext3rd/evolve/__init__.py b/hgext3rd/evolve/__init__.py
> --- a/hgext3rd/evolve/__init__.py
> +++ b/hgext3rd/evolve/__init__.py
> @@ -364,9 +364,9 @@
>  eh.merge(compat.eh)
>  eh.merge(cmdrewrite.eh)
>  eh.merge(rewind.eh)
> -uisetup = eh.final_uisetup
> -extsetup = eh.final_extsetup
> -reposetup = eh.final_reposetup
> +uisetup = eh.finaluisetup
> +extsetup = eh.finalextsetup
> +reposetup = eh.finalreposetup
>  cmdtable = eh.cmdtable
>  configtable = eh.configtable
>  
> diff --git a/hgext3rd/evolve/exthelper.py b/hgext3rd/evolve/exthelper.py
> --- a/hgext3rd/evolve/exthelper.py
> +++ b/hgext3rd/evolve/exthelper.py
> @@ -78,7 +78,7 @@
>              else:
>                  self.configtable[section] = items
>  
> -    def final_uisetup(self, ui):
> +    def finaluisetup(self, ui):
>          """Method to be used as the extension uisetup
>  
>          The following operations belong here:
> @@ -109,7 +109,7 @@
>          for c in self._uicallables:
>              c(ui)
>  
> -    def final_uipopulate(self, ui):
> +    def finaluipopulate(self, ui):
>          """Method to be used as the extension uipopulate
>  
>          This is called once per ui instance to:
> @@ -121,7 +121,7 @@
>          for c in self._uipopulatecallables:
>              c(ui)
>  
> -    def final_extsetup(self, ui):
> +    def finalextsetup(self, ui):
>          """Method to be used as a the extension extsetup
>  
>          The following operations belong here:
> @@ -169,7 +169,7 @@
>          for c in self._extcallables:
>              c(ui)
>  
> -    def final_reposetup(self, ui, repo):
> +    def finalreposetup(self, ui, repo):
>          """Method to be used as the extension reposetup
>  
>          The following operations belong here:
> diff --git a/hgext3rd/evolve/serveronly.py b/hgext3rd/evolve/serveronly.py
> --- a/hgext3rd/evolve/serveronly.py
> +++ b/hgext3rd/evolve/serveronly.py
> @@ -45,9 +45,9 @@
>  eh.merge(compat.eh)
>  eh.merge(obscache.eh)
>  eh.merge(obsexchange.eh)
> -uisetup = eh.final_uisetup
> -extsetup = eh.final_extsetup
> -reposetup = eh.final_reposetup
> +uisetup = eh.finaluisetup
> +extsetup = eh.finalextsetup
> +reposetup = eh.finalreposetup
>  cmdtable = eh.cmdtable
>  configtable = eh.configtable
>  
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Patch

diff --git a/hgext3rd/evolve/__init__.py b/hgext3rd/evolve/__init__.py
--- a/hgext3rd/evolve/__init__.py
+++ b/hgext3rd/evolve/__init__.py
@@ -364,9 +364,9 @@ 
 eh.merge(compat.eh)
 eh.merge(cmdrewrite.eh)
 eh.merge(rewind.eh)
-uisetup = eh.final_uisetup
-extsetup = eh.final_extsetup
-reposetup = eh.final_reposetup
+uisetup = eh.finaluisetup
+extsetup = eh.finalextsetup
+reposetup = eh.finalreposetup
 cmdtable = eh.cmdtable
 configtable = eh.configtable
 
diff --git a/hgext3rd/evolve/exthelper.py b/hgext3rd/evolve/exthelper.py
--- a/hgext3rd/evolve/exthelper.py
+++ b/hgext3rd/evolve/exthelper.py
@@ -78,7 +78,7 @@ 
             else:
                 self.configtable[section] = items
 
-    def final_uisetup(self, ui):
+    def finaluisetup(self, ui):
         """Method to be used as the extension uisetup
 
         The following operations belong here:
@@ -109,7 +109,7 @@ 
         for c in self._uicallables:
             c(ui)
 
-    def final_uipopulate(self, ui):
+    def finaluipopulate(self, ui):
         """Method to be used as the extension uipopulate
 
         This is called once per ui instance to:
@@ -121,7 +121,7 @@ 
         for c in self._uipopulatecallables:
             c(ui)
 
-    def final_extsetup(self, ui):
+    def finalextsetup(self, ui):
         """Method to be used as a the extension extsetup
 
         The following operations belong here:
@@ -169,7 +169,7 @@ 
         for c in self._extcallables:
             c(ui)
 
-    def final_reposetup(self, ui, repo):
+    def finalreposetup(self, ui, repo):
         """Method to be used as the extension reposetup
 
         The following operations belong here:
diff --git a/hgext3rd/evolve/serveronly.py b/hgext3rd/evolve/serveronly.py
--- a/hgext3rd/evolve/serveronly.py
+++ b/hgext3rd/evolve/serveronly.py
@@ -45,9 +45,9 @@ 
 eh.merge(compat.eh)
 eh.merge(obscache.eh)
 eh.merge(obsexchange.eh)
-uisetup = eh.final_uisetup
-extsetup = eh.final_extsetup
-reposetup = eh.final_reposetup
+uisetup = eh.finaluisetup
+extsetup = eh.finalextsetup
+reposetup = eh.finalreposetup
 cmdtable = eh.cmdtable
 configtable = eh.configtable