Patchwork D5429: check-commit: disallow capitalization only right after topic

login
register
mail settings
Submitter phabricator
Date Dec. 15, 2018, 1:36 a.m.
Message ID <3f979125d1a952da0f32a3b3230cf338@localhost.localdomain>
Download mbox | patch
Permalink /patch/37168/
State Not Applicable
Headers show

Comments

phabricator - Dec. 15, 2018, 1:36 a.m.
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG7da54cff8743: check-commit: disallow capitalization only right after topic (authored by martinvonz, committed by ).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D5429?vs=12860&id=12865

REVISION DETAIL
  https://phab.mercurial-scm.org/D5429

AFFECTED FILES
  contrib/check-commit

CHANGE DETAILS




To: martinvonz, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/contrib/check-commit b/contrib/check-commit
--- a/contrib/check-commit
+++ b/contrib/check-commit
@@ -34,7 +34,7 @@ 
     (commitheader + r"(?!merge with )[^#]\S+[^:] ",
      "summary line doesn't start with 'topic: '"),
     (afterheader + r"[A-Z][a-z]\S+", "don't capitalize summary lines"),
-    (afterheader + r"[^\n]*: *[A-Z][a-z]\S+", "don't capitalize summary lines"),
+    (afterheader + r"^\S+: *[A-Z][a-z]\S+", "don't capitalize summary lines"),
     (afterheader + r"\S*[^A-Za-z0-9-_]\S*: ",
      "summary keyword should be most user-relevant one-word command or topic"),
     (afterheader + r".*\.\s*\n", "don't add trailing period on summary line"),