Patchwork [08,of,11] comments: fix minor spelling issues found with spell checker

login
register
mail settings
Submitter Mads Kiilerich
Date Feb. 20, 2014, 1:43 a.m.
Message ID <a03c3f91bc52bad6796d.1392860612@localhost.localdomain>
Download mbox | patch
Permalink /patch/3714/
State Accepted
Commit 2025315cfb0cedc681e4251ca3152990e86309d6
Headers show

Comments

Mads Kiilerich - Feb. 20, 2014, 1:43 a.m.
# HG changeset patch
# User Mads Kiilerich <madski@unity3d.com>
# Date 1392860341 -3600
#      Thu Feb 20 02:39:01 2014 +0100
# Node ID a03c3f91bc52bad6796d83c9a723e64f74f8e9fa
# Parent  7e1fd5d7a88af2608ae0a9a5ed8b7940036ebd0f
comments: fix minor spelling issues found with spell checker
Simon Heimberg - Feb. 20, 2014, 11:32 a.m.
On 2014-02-20 02:43, Mads Kiilerich wrote:
> # HG changeset patch
> # User Mads Kiilerich <madski@unity3d.com>
> # Date 1392860341 -3600
> #      Thu Feb 20 02:39:01 2014 +0100
> # Node ID a03c3f91bc52bad6796d83c9a723e64f74f8e9fa
> # Parent  7e1fd5d7a88af2608ae0a9a5ed8b7940036ebd0f
> comments: fix minor spelling issues found with spell checker
>

What spell checker are you using? Does it only check strings and 
comments? I'd like one too.

> diff --git a/mercurial/minirst.py b/mercurial/minirst.py
> --- a/mercurial/minirst.py
> +++ b/mercurial/minirst.py
> @@ -109,7 +109,7 @@ def findliteralblocks(blocks):
>               elif len(blocks[i]['lines']) == 1 and \
>                    blocks[i]['lines'][0].lstrip(' ').startswith('.. ') and \
>                    blocks[i]['lines'][0].find(' ', 3) == -1:
> -                # directive on its onw line, not a literal block
> +                # directive on its own line, not a literal block

This is mine... I would like to avoid this in the feature.

>                   i += 1
>                   continue
<snip>
Mads Kiilerich - Feb. 20, 2014, 2:35 p.m.
On 02/20/2014 12:32 PM, Simon Heimberg wrote:
> On 2014-02-20 02:43, Mads Kiilerich wrote:
>> # HG changeset patch
>> # User Mads Kiilerich <madski@unity3d.com>
>> # Date 1392860341 -3600
>> #      Thu Feb 20 02:39:01 2014 +0100
>> # Node ID a03c3f91bc52bad6796d83c9a723e64f74f8e9fa
>> # Parent  7e1fd5d7a88af2608ae0a9a5ed8b7940036ebd0f
>> comments: fix minor spelling issues found with spell checker
>>
>
> What spell checker are you using? Does it only check strings and 
> comments? I'd like one too.

https://bitbucket.org/kiilerix/mercurial-crew/src/0960ec3ab3f642acaeb24e8acad25c91676bf9f3/spellcheck0

>
>> diff --git a/mercurial/minirst.py b/mercurial/minirst.py
>> --- a/mercurial/minirst.py
>> +++ b/mercurial/minirst.py
>> @@ -109,7 +109,7 @@ def findliteralblocks(blocks):
>>               elif len(blocks[i]['lines']) == 1 and \
>>                    blocks[i]['lines'][0].lstrip(' ').startswith('.. 
>> ') and \
>>                    blocks[i]['lines'][0].find(' ', 3) == -1:
>> -                # directive on its onw line, not a literal block
>> +                # directive on its own line, not a literal block
>
> This is mine... I would like to avoid this in the feature.

The best way to do that is probably to use a smart editor with spell 
checking and fancy markup ... such as vim ":set spell".

/Mads

Patch

diff --git a/mercurial/minirst.py b/mercurial/minirst.py
--- a/mercurial/minirst.py
+++ b/mercurial/minirst.py
@@ -109,7 +109,7 @@  def findliteralblocks(blocks):
             elif len(blocks[i]['lines']) == 1 and \
                  blocks[i]['lines'][0].lstrip(' ').startswith('.. ') and \
                  blocks[i]['lines'][0].find(' ', 3) == -1:
-                # directive on its onw line, not a literal block
+                # directive on its own line, not a literal block
                 i += 1
                 continue
             else:
@@ -382,7 +382,7 @@  def addmargins(blocks):
             blocks[i]['type'] in ('bullet', 'option', 'field')):
             i += 1
         elif not blocks[i - 1]['lines']:
-            # no lines in previous block, do not seperate
+            # no lines in previous block, do not separate
             i += 1
         else:
             blocks.insert(i, dict(lines=[''], indent=0, type='margin'))
diff --git a/mercurial/obsolete.py b/mercurial/obsolete.py
--- a/mercurial/obsolete.py
+++ b/mercurial/obsolete.py
@@ -766,7 +766,7 @@  def _computeextinctset(repo):
 def _computebumpedset(repo):
     """the set of revs trying to obsolete public revisions"""
     bumped = set()
-    # utils function (avoid attribut lookup in the loop)
+    # utils function (avoid attribute lookup in the loop)
     phase = repo._phasecache.phase # would be faster to grab the full list
     public = phases.public
     cl = repo.changelog
diff --git a/mercurial/repoview.py b/mercurial/repoview.py
--- a/mercurial/repoview.py
+++ b/mercurial/repoview.py
@@ -96,7 +96,7 @@  def computeimpactable(repo):
 
 # function to compute filtered set
 #
-# When addding a new filter you MUST update the table at:
+# When adding a new filter you MUST update the table at:
 #     mercurial.branchmap.subsettable
 # Otherwise your filter will have to recompute all its branches cache
 # from scratch (very slow).