Patchwork [Bug,6030] New: test-https test failure

login
register
mail settings
Submitter mercurial-bugs@mercurial-scm.org
Date Dec. 2, 2018, 12:34 p.m.
Message ID <bug-6030-285@https.bz.mercurial-scm.org/>
Download mbox | patch
Permalink /patch/36899/
State Not Applicable
Headers show

Comments

mercurial-bugs@mercurial-scm.org - Dec. 2, 2018, 12:34 p.m.
https://bz.mercurial-scm.org/show_bug.cgi?id=6030

            Bug ID: 6030
           Summary: test-https test failure
           Product: Mercurial
           Version: 4.8
          Hardware: All
                OS: NetBSD
            Status: UNCONFIRMED
          Severity: bug
          Priority: wish
         Component: Mercurial
          Assignee: bugzilla@mercurial-scm.org
          Reporter: tk@giga.or.at
                CC: mercurial-devel@mercurial-scm.org

mercurial-4.8 fails the test-https test on NetBSD-8.99.26/amd64. The output is:

-  [255]
+  5fed3813f7f5

 Changing the cipher string works

@@ -624,7 +620,7 @@

   $ P="$CERTSDIR" hg id https://localhost:$HGPORT/
   warning: connecting to localhost using legacy security technology (TLS 1.0);
see https://mercurial-scm.org/wiki/SecureConnections for more info (?)
-  abort: error: *handshake failure* (glob)
+  abort: error: [SSL] tlsv13 alert certificate required (_ssl.c:1941)
   [255]

 with client certificate:

ERROR: test-https.t output changed


In case it matters, this version of NetBSD uses openssl v1.1.

Patch

--- /scratch/devel/py-mercurial/work/mercurial-4.8/tests/test-https.t
+++ /scratch/devel/py-mercurial/work/mercurial-4.8/tests/test-https.t.err
@@ -355,15 +355,11 @@ 
 Setting ciphers to an invalid value aborts
   $ P="$CERTSDIR" hg --config hostsecurity.ciphers=invalid -R copy-pull id
https://localhost:$HGPORT/
   warning: connecting to localhost using legacy security technology (TLS 1.0);
see https://mercurial-scm.org/wiki/SecureConnections for more info (?)
-  abort: could not set ciphers: No cipher can be selected.
-  (change cipher string (invalid) in config)
-  [255]
+  5fed3813f7f5

   $ P="$CERTSDIR" hg --config hostsecurity.localhost:ciphers=invalid -R
copy-pull id https://localhost:$HGPORT/
   warning: connecting to localhost using legacy security technology (TLS 1.0);
see https://mercurial-scm.org/wiki/SecureConnections for more info (?)
-  abort: could not set ciphers: No cipher can be selected.
-  (change cipher string (invalid) in config)