Patchwork [5,of,5,FOLLOW-UP] revlog: update the documentation for `trim_endidx`

login
register
mail settings
Submitter Boris Feld
Date Nov. 26, 2018, 6:33 p.m.
Message ID <498fc4b8da0cf147315b.1543257234@localhost.localdomain>
Download mbox | patch
Permalink /patch/36790/
State Accepted
Headers show

Comments

Boris Feld - Nov. 26, 2018, 6:33 p.m.
# HG changeset patch
# User Boris Feld <boris.feld@octobus.net>
# Date 1543188192 -3600
#      Mon Nov 26 00:23:12 2018 +0100
# Node ID 498fc4b8da0cf147315b63b4580ef9b6a36e3911
# Parent  7dc2fade8ee58c0554b6f25484a4481ac625ce84
# EXP-Topic follow-up-yuya
# Available At https://bitbucket.org/octobus/mercurial-devel/
#              hg pull https://bitbucket.org/octobus/mercurial-devel/ -r 498fc4b8da0c
revlog: update the documentation for `trim_endidx`

The function role drifted since the function was commented.

Patch

diff --git a/mercurial/cext/revlog.c b/mercurial/cext/revlog.c
--- a/mercurial/cext/revlog.c
+++ b/mercurial/cext/revlog.c
@@ -1086,7 +1086,7 @@  index_segment_span(indexObject *self, Py
 	return (end_offset - start_offset) + (int64_t)end_size;
 }
 
-/* returns revs[startidx:endidx] without empty trailing revs */
+/* returns endidx so that revs[startidx:endidx] has no empty trailing revs */
 static Py_ssize_t trim_endidx(indexObject *self, const Py_ssize_t *revs,
                               Py_ssize_t startidx, Py_ssize_t endidx)
 {