Patchwork localrepo: correct docstring of filectx()

login
register
mail settings
Submitter Yuya Nishihara
Date Nov. 25, 2018, 1:50 p.m.
Message ID <3cba13b2e62284f3bd4e.1543153806@mimosa>
Download mbox | patch
Permalink /patch/36768/
State Accepted
Headers show

Comments

Yuya Nishihara - Nov. 25, 2018, 1:50 p.m.
# HG changeset patch
# User Yuya Nishihara <yuya@tcha.org>
# Date 1543153194 -32400
#      Sun Nov 25 22:39:54 2018 +0900
# Node ID 3cba13b2e62284f3bd4ed3219864b7418a99f596
# Parent  cfaf3843491bde30916b89180d5f67561a22da28
localrepo: correct docstring of filectx()

The same reason as b6c2543e1dd8. It can't be any changeset specifiers but
revision number.
Pulkit Goyal - Nov. 26, 2018, 10:47 a.m.
On Sun, Nov 25, 2018 at 4:51 PM Yuya Nishihara <yuya@tcha.org> wrote:

> # HG changeset patch
> # User Yuya Nishihara <yuya@tcha.org>
> # Date 1543153194 -32400
> #      Sun Nov 25 22:39:54 2018 +0900
> # Node ID 3cba13b2e62284f3bd4ed3219864b7418a99f596
> # Parent  cfaf3843491bde30916b89180d5f67561a22da28
> localrepo: correct docstring of filectx()
>
> The same reason as b6c2543e1dd8. It can't be any changeset specifiers but
> revision number.
>

Queued this, many thanks!

Patch

diff --git a/mercurial/localrepo.py b/mercurial/localrepo.py
--- a/mercurial/localrepo.py
+++ b/mercurial/localrepo.py
@@ -1587,7 +1587,7 @@  class localrepository(object):
                         self.dirstate.copy(None, f)
 
     def filectx(self, path, changeid=None, fileid=None, changectx=None):
-        """changeid can be a changeset revision, node, or tag.
+        """changeid must be a changeset revision, if specified.
            fileid can be a file revision or node."""
         return context.filectx(self, path, changeid, fileid,
                                changectx=changectx)