Patchwork [4,of,4,V2] perf: disable revlogs clearing in `perftags` by default

login
register
mail settings
Submitter Boris Feld
Date Nov. 23, 2018, 5:25 p.m.
Message ID <7677f117fbecdb04e993.1542993950@localhost.localdomain>
Download mbox | patch
Permalink /patch/36753/
State New
Headers show

Comments

Boris Feld - Nov. 23, 2018, 5:25 p.m.
# HG changeset patch
# User Boris Feld <boris.feld@octobus.net>
# Date 1542735864 0
#      Tue Nov 20 17:44:24 2018 +0000
# Node ID 7677f117fbecdb04e993ad84af1591b395762f00
# Parent  438718ecc3058c55b0d5a4a9742b3325b83e78cc
# EXP-Topic perf-tags
# Available At https://bitbucket.org/octobus/mercurial-devel/
#              hg pull https://bitbucket.org/octobus/mercurial-devel/ -r 7677f117fbec
perf: disable revlogs clearing in `perftags` by default

This aligns things with what `perfbookmarks` does. I decided to disable the
revlogs clearing by default to focus on the core logic by default, ignoring
side effects.

If we prefer to emphasize the side effect, we can instead keep this on in
`perftags` and enable it by default in `perfbookmarks`.

Patch

diff --git a/contrib/perf.py b/contrib/perf.py
--- a/contrib/perf.py
+++ b/contrib/perf.py
@@ -530,7 +530,7 @@  def perfheads(ui, repo, **opts):
 
 @command(b'perftags', formatteropts+
         [
-            (b'', b'clear-revlogs', True, 'refresh changelog and manifest'),
+            (b'', b'clear-revlogs', False, 'refresh changelog and manifest'),
         ])
 def perftags(ui, repo, **opts):
     import mercurial.changelog