Patchwork [1,of,8] perf: explicitly pass title as a keyword argument in `perfdiffwd`

login
register
mail settings
Submitter Boris Feld
Date Nov. 21, 2018, 6:33 p.m.
Message ID <954159d40a5f4bf43465.1542825231@localhost.localdomain>
Download mbox | patch
Permalink /patch/36698/
State Accepted
Headers show

Comments

Boris Feld - Nov. 21, 2018, 6:33 p.m.
# HG changeset patch
# User Boris Feld <boris.feld@octobus.net>
# Date 1542668549 0
#      Mon Nov 19 23:02:29 2018 +0000
# Node ID 954159d40a5f4bf43465c50cc97261ea139f0032
# Parent  dba590f27c7abacbd7e9b27f3e06822bb0b339cb
# EXP-Topic perf-ignore
# Available At https://bitbucket.org/octobus/mercurial-devel/
#              hg pull https://bitbucket.org/octobus/mercurial-devel/ -r 954159d40a5f
perf: explicitly pass title as a keyword argument in `perfdiffwd`

This will help to update the timer function arguments in a later changeset.
Pulkit Goyal - Nov. 22, 2018, 9:30 a.m.
On Wed, Nov 21, 2018 at 9:36 PM Boris Feld <boris.feld@octobus.net> wrote:

> # HG changeset patch
> # User Boris Feld <boris.feld@octobus.net>
> # Date 1542668549 0
> #      Mon Nov 19 23:02:29 2018 +0000
> # Node ID 954159d40a5f4bf43465c50cc97261ea139f0032
> # Parent  dba590f27c7abacbd7e9b27f3e06822bb0b339cb
> # EXP-Topic perf-ignore
> # Available At https://bitbucket.org/octobus/mercurial-devel/
> #              hg pull https://bitbucket.org/octobus/mercurial-devel/ -r
> 954159d40a5f
> perf: explicitly pass title as a keyword argument in `perfdiffwd`
>
> This will help to update the timer function arguments in a later changeset.
>

Queued 1-3, many thanks!

Patch

diff --git a/contrib/perf.py b/contrib/perf.py
--- a/contrib/perf.py
+++ b/contrib/perf.py
@@ -1404,7 +1404,7 @@  def perfdiffwd(ui, repo, **opts):
             ui.popbuffer()
         diffopt = diffopt.encode('ascii')
         title = b'diffopts: %s' % (diffopt and (b'-' + diffopt) or b'none')
-        timer(d, title)
+        timer(d, title=title)
     fm.end()
 
 @command(b'perfrevlogindex', revlogopts + formatteropts,