Patchwork [2,of,5,V2] ui: unify argument name of ui.log()

login
register
mail settings
Submitter Yuya Nishihara
Date Nov. 21, 2018, 2:03 p.m.
Message ID <84a17834f4aa3bafba00.1542808987@mimosa>
Download mbox | patch
Permalink /patch/36688/
State Accepted
Headers show

Comments

Yuya Nishihara - Nov. 21, 2018, 2:03 p.m.
# HG changeset patch
# User Yuya Nishihara <yuya@tcha.org>
# Date 1541926763 -32400
#      Sun Nov 11 17:59:23 2018 +0900
# Node ID 84a17834f4aa3bafba00b1b448d1a90dadd6d9e7
# Parent  96d5d57ab30e831b11e48f92936c3ebcfb3e7510
ui: unify argument name of ui.log()

It's called an "event" in both blackbox and logtoprocess.

Patch

diff --git a/mercurial/ui.py b/mercurial/ui.py
--- a/mercurial/ui.py
+++ b/mercurial/ui.py
@@ -1709,10 +1709,10 @@  class ui(object):
         '''exists only so low-level modules won't need to import scmutil'''
         return scmutil.progress(self, topic, unit, total)
 
-    def log(self, service, *msg, **opts):
+    def log(self, event, *msg, **opts):
         '''hook for logging facility extensions
 
-        service should be a readily-identifiable subsystem, which will
+        event should be a readily-identifiable subsystem, which will
         allow filtering.
 
         *msg should be a newline-terminated format string to log, and