Patchwork [08,of,14] sparse-revlog: add a `index_get_start` function in C

login
register
mail settings
Submitter Boris Feld
Date Nov. 12, 2018, 9:55 a.m.
Message ID <524f8117280d1a363016.1542016543@localhost.localdomain>
Download mbox | patch
Permalink /patch/36516/
State Accepted
Headers show

Comments

Boris Feld - Nov. 12, 2018, 9:55 a.m.
# HG changeset patch
# User Boris Feld <boris.feld@octobus.net>
# Date 1541785348 -3600
#      Fri Nov 09 18:42:28 2018 +0100
# Node ID 524f8117280d1a36301653c463f969fbc2391a7c
# Parent  b77a6b74ef31e1b3706c1c6127a15eede0334f71
# EXP-Topic sparse-perf
# Available At https://bitbucket.org/octobus/mercurial-devel/
#              hg pull https://bitbucket.org/octobus/mercurial-devel/ -r 524f8117280d
sparse-revlog: add a `index_get_start` function in C

We are about to implement a native version of `slicechunktodensity`. For
clarity, we introduce the helper functions first. This new function provides
an efficient way to retrieve some of the information needed by
`slicechunktodensity`.

Patch

diff --git a/mercurial/cext/revlog.c b/mercurial/cext/revlog.c
--- a/mercurial/cext/revlog.c
+++ b/mercurial/cext/revlog.c
@@ -179,6 +179,27 @@  static inline int index_get_parents(inde
 	return 0;
 }
 
+static inline uint64_t index_get_start(indexObject *self, Py_ssize_t rev)
+{
+	uint64_t offset;
+	if (rev >= self->length) {
+		PyObject *tuple =
+		    PyList_GET_ITEM(self->added, rev - self->length);
+		offset = (uint64_t)PyInt_AS_LONG(PyTuple_GET_ITEM(tuple, 0));
+	} else {
+		const char *data = index_deref(self, rev);
+		offset = getbe32(data + 4);
+		if (rev == 0) /* mask out version number for the first entry */
+			offset &= 0xFFFF;
+		else {
+			uint32_t offset_high = getbe32(data);
+			offset |= ((uint64_t)offset_high) << 32;
+		}
+	}
+	offset = offset >> 16;
+	return offset;
+}
+
 /*
  * RevlogNG format (all in big endian, data may be inlined):
  *    6 bytes: offset