Patchwork [4,of,4,accept-scripts] land: add test documenting contents of take.log

login
register
mail settings
Submitter Augie Fackler
Date Nov. 8, 2018, 12:57 a.m.
Message ID <3e0f9891db118868fe54.1541638651@augie-macbookpro2.roam.corp.google.com>
Download mbox | patch
Permalink /patch/36466/
State New
Headers show

Comments

Augie Fackler - Nov. 8, 2018, 12:57 a.m.
# HG changeset patch
# User Augie Fackler <raf@durin42.com>
# Date 1541634897 18000
#      Wed Nov 07 18:54:57 2018 -0500
# Node ID 3e0f9891db118868fe54315231ba52fc84501a37
# Parent  69c1fd928cf6668e4ddbd6d26ebb53bb75e374c5
land: add test documenting contents of take.log

I wrote this commit as a child of 66e6, before my refactor which broke
this functionality. That it passes after rebasing proves that my fix
actually fixed things to the old behavior. :)
via Mercurial-devel - Nov. 8, 2018, 6:12 a.m.
On Wed, Nov 7, 2018 at 5:06 PM Augie Fackler <raf@durin42.com> wrote:

> # HG changeset patch
> # User Augie Fackler <raf@durin42.com>
> # Date 1541634897 18000
> #      Wed Nov 07 18:54:57 2018 -0500
> # Node ID 3e0f9891db118868fe54315231ba52fc84501a37
> # Parent  69c1fd928cf6668e4ddbd6d26ebb53bb75e374c5
> land: add test documenting contents of take.log
>

This series looks good to me. Thanks! I'll let Kevin queue it (because I
have never done that and I'm too lazy to figure out how).
Augie Fackler - Nov. 9, 2018, 3:44 p.m.
> On Nov 8, 2018, at 00:12, Martin von Zweigbergk <martinvonz@google.com> wrote:
> 
> 
> 
> On Wed, Nov 7, 2018 at 5:06 PM Augie Fackler <raf@durin42.com> wrote:
>> # HG changeset patch
>> # User Augie Fackler <raf@durin42.com>
>> # Date 1541634897 18000
>> #      Wed Nov 07 18:54:57 2018 -0500
>> # Node ID 3e0f9891db118868fe54315231ba52fc84501a37
>> # Parent  69c1fd928cf6668e4ddbd6d26ebb53bb75e374c5
>> land: add test documenting contents of take.log
>> 
> This series looks good to me. Thanks! I'll let Kevin queue it (because I have never done that and I'm too lazy to figure out how).

If you're okay with it, I'll push it per your review and write up the associated infra change to deploy it so we start collecting data again.
via Mercurial-devel - Nov. 9, 2018, 3:46 p.m.
Sounds good to me.

On Fri, Nov 9, 2018, 07:45 Augie Fackler <raf@durin42.com wrote:

>
>
> > On Nov 8, 2018, at 00:12, Martin von Zweigbergk <martinvonz@google.com>
> wrote:
> >
> >
> >
> > On Wed, Nov 7, 2018 at 5:06 PM Augie Fackler <raf@durin42.com> wrote:
> >> # HG changeset patch
> >> # User Augie Fackler <raf@durin42.com>
> >> # Date 1541634897 18000
> >> #      Wed Nov 07 18:54:57 2018 -0500
> >> # Node ID 3e0f9891db118868fe54315231ba52fc84501a37
> >> # Parent  69c1fd928cf6668e4ddbd6d26ebb53bb75e374c5
> >> land: add test documenting contents of take.log
> >>
> > This series looks good to me. Thanks! I'll let Kevin queue it (because I
> have never done that and I'm too lazy to figure out how).
>
> If you're okay with it, I'll push it per your review and write up the
> associated infra change to deploy it so we start collecting data again.
Augie Fackler - Nov. 12, 2018, 6:17 p.m.
These scripts are now live, and the matching infra change is out for review.

> On Nov 9, 2018, at 10:46, Martin von Zweigbergk <martinvonz@google.com> wrote:
> 
> Sounds good to me. 
> 
> On Fri, Nov 9, 2018, 07:45 Augie Fackler <raf@durin42.com <mailto:raf@durin42.com> wrote:
> 
> 
> > On Nov 8, 2018, at 00:12, Martin von Zweigbergk <martinvonz@google.com <mailto:martinvonz@google.com>> wrote:
> > 
> > 
> > 
> > On Wed, Nov 7, 2018 at 5:06 PM Augie Fackler <raf@durin42.com <mailto:raf@durin42.com>> wrote:
> >> # HG changeset patch
> >> # User Augie Fackler <raf@durin42.com <mailto:raf@durin42.com>>
> >> # Date 1541634897 18000
> >> #      Wed Nov 07 18:54:57 2018 -0500
> >> # Node ID 3e0f9891db118868fe54315231ba52fc84501a37
> >> # Parent  69c1fd928cf6668e4ddbd6d26ebb53bb75e374c5
> >> land: add test documenting contents of take.log
> >> 
> > This series looks good to me. Thanks! I'll let Kevin queue it (because I have never done that and I'm too lazy to figure out how).
> 
> If you're okay with it, I'll push it per your review and write up the associated infra change to deploy it so we start collecting data again.

Patch

diff --git a/tests/test-land.t b/tests/test-land.t
--- a/tests/test-land.t
+++ b/tests/test-land.t
@@ -22,6 +22,9 @@  If only r1 is accepted, land pulls it in
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     Add alpha.
   
+We log the acceptance in the take.log file in the target:
+  $ cat target/.hg/take.log
+  eb8972173e1758e823d2198d43f85bf17fba7212 carol alice bob
 
 More complicated example built using debugbuilddag. This emulates a bug
 encountered during the hg 4.6 freeze.