Patchwork profiling: move default mode to "real" time

login
register
mail settings
Submitter Boris Feld
Date Oct. 17, 2018, 1:35 p.m.
Message ID <63cac0b435c518d8007d.1539783359@localhost.localdomain>
Download mbox | patch
Permalink /patch/36080/
State New
Headers show

Comments

Boris Feld - Oct. 17, 2018, 1:35 p.m.
# HG changeset patch
# User Boris Feld <boris.feld@octobus.net>
# Date 1534549478 -7200
#      Sat Aug 18 01:44:38 2018 +0200
# Node ID 63cac0b435c518d8007df572c94341328a2d1dde
# Parent  b95b48a55c36050852b46868f4e4f750a29d8754
# EXP-Topic profiling-mode
# Available At https://bitbucket.org/octobus/mercurial-devel/
#              hg pull https://bitbucket.org/octobus/mercurial-devel/ -r 63cac0b435c5
profiling: move default mode to "real" time

Mercurial operations involve a lot of disks or network access. These impact
command runtime significantly and it seems important to report them in our
default profiling output.

Having the right default means that we don't forget them when asking people to
produces profiling traces or when doing profiling ourselves.

Moving to "real time" by default will remove the need to think about
activating it on most occasions. The "CPU" time-based profiling is still
accessible when necessary.

Patch

diff --git a/mercurial/configitems.py b/mercurial/configitems.py
--- a/mercurial/configitems.py
+++ b/mercurial/configitems.py
@@ -904,7 +904,7 @@  coreconfigitem('profiling', 'statformat'
     default='hotpath',
 )
 coreconfigitem('profiling', 'time-track',
-    default='cpu',
+    default='real',
 )
 coreconfigitem('profiling', 'type',
     default='stat',