Patchwork [2,of,2] revset: changed getset so that it can return a lazyset

login
register
mail settings
Submitter Lucas Moscovicz
Date Feb. 11, 2014, 5:52 p.m.
Message ID <3e472c6e812daadda941.1392141169@dev1037.prn2.facebook.com>
Download mbox | patch
Permalink /patch/3568/
State Accepted
Commit b68984d288d4638667b5a1a0587de58236551a38
Headers show

Comments

Matt Mackall - Feb. 11, 2014, 4:31 p.m.
On Tue, 2014-02-11 at 09:52 -0800, Lucas Moscovicz wrote:
> # HG changeset patch
> # User Lucas Moscovicz <lmoscovicz@fb.com>
> # Date 1390951154 28800
> #      Tue Jan 28 15:19:14 2014 -0800
> # Node ID 3e472c6e812daadda941fadffd9ff404d0c1d175
> # Parent  daa72c03125908e686e6854c8141f3e584128ea4
> revset: changed getset so that it can return a lazyset

Awesome, these are queued for default.
Lucas Moscovicz - Feb. 11, 2014, 5:52 p.m.
# HG changeset patch
# User Lucas Moscovicz <lmoscovicz@fb.com>
# Date 1390951154 28800
#      Tue Jan 28 15:19:14 2014 -0800
# Node ID 3e472c6e812daadda941fadffd9ff404d0c1d175
# Parent  daa72c03125908e686e6854c8141f3e584128ea4
revset: changed getset so that it can return a lazyset

Not converting it manually to a baseset anymore. At this point every revset
method should return a baseset typed structure.

Patch

diff --git a/mercurial/revset.py b/mercurial/revset.py
--- a/mercurial/revset.py
+++ b/mercurial/revset.py
@@ -195,7 +195,7 @@ 
 def getset(repo, subset, x):
     if not x:
         raise error.ParseError(_("missing argument"))
-    return baseset(methods[x[0]](repo, subset, *x[1:]))
+    return methods[x[0]](repo, subset, *x[1:])
 
 def _getrevsource(repo, r):
     extra = repo[r].extra()